actions/download-artifact
1
0
Fork 0
mirror of https://github.com/actions/download-artifact.git synced 2025-07-26 00:18:30 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

move download finish to then statement

Browse source 
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
This commit is contained in:
Eli Uriegas 2021-05-19 15:30:55 -07:00
parent fdf1695da1
commit c7a6943d3b
No known key found for this signature in database
GPG key ID: EE2C3B4893010973
3 changed files with 9 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

9
dist/index.js vendored
View file

@ -31181,10 +31181,7 @@ function doDownload(s3, s3Bucket, fileKey, localKey) {
core.debug(`S3 download uri: s3://${s3Bucket}/${fileKey}`);
const readStream = s3.getObject(getObjectParams).createReadStream();
readStream.pipe(writeStream);
readStream.on('close', () => {
core.info(`Finished download: ${localKey}`);
resolve;
});
readStream.on('close', resolve);
readStream.on('error', reject);
});
}
@ -31221,7 +31218,9 @@ function run() {
continue;
}
const localKey = path_1.default.join(resolvedPath, fileObject.Key.replace(s3Prefix, ''));
yield doDownload(s3, s3Bucket, fileObject.Key, localKey);
yield doDownload(s3, s3Bucket, fileObject.Key, localKey).then(() => {
core.info(`Finished download: ${localKey}`);
});
}
// output the directory that the artifact(s) was/were downloaded to
// if no path is provided, an empty string resolves to the current working directory

2
package.json
View file

@ -5,7 +5,7 @@
"main": "dist/index.js",
"scripts": {
"build": "tsc",
"release": "ncc build src/download-artifact.ts && git add -f dist/",
"release": "ncc build src/download-artifact.ts",
"check-all": "concurrently \"npm:format-check\" \"npm:lint\" \"npm:build\"",
"format": "prettier --write **/*.ts",
"format-check": "prettier --check **/*.ts",

9
src/download-artifact.ts
View file

@ -24,10 +24,7 @@ function doDownload(
core.debug(`S3 download uri: s3://${s3Bucket}/${fileKey}`)
const readStream = s3.getObject(getObjectParams).createReadStream()
readStream.pipe(writeStream)
readStream.on('close', () => {
core.info(`Finished download: ${localKey}`)
resolve
})
readStream.on('close', resolve)
readStream.on('error', reject)
})
}
@ -67,7 +64,9 @@ async function run(): Promise<void> {
resolvedPath,
fileObject.Key.replace(s3Prefix, '')
)
await doDownload(s3, s3Bucket, fileObject.Key, localKey)
await doDownload(s3, s3Bucket, fileObject.Key, localKey).then(() => {
core.info(`Finished download: ${localKey}`)
})
}
// output the directory that the artifact(s) was/were downloaded to
// if no path is provided, an empty string resolves to the current working directory