refactor: dont try all files if not defined

This commit is contained in:
Jozef Steinhübl 2024-05-08 11:41:47 +02:00
parent 93c92af672
commit 1cea06d8fc
No known key found for this signature in database
GPG key ID: E6BC90C91973B08F

View file

@ -35,22 +35,16 @@ const FILE_VERSION_READERS = {
".bumrc": (content: string) => content, ".bumrc": (content: string) => content,
}; };
export function readVersionFromFile( export function readVersionFromFile(file: string): string | undefined {
files: string | string[]
): string | undefined {
const cwd = process.env.GITHUB_WORKSPACE; const cwd = process.env.GITHUB_WORKSPACE;
if (!cwd) { if (!cwd) {
return; return;
} }
if (!files) { if (!file) {
warning("No version file specified, trying all known files."); return;
return readVersionFromFile(Object.keys(FILE_VERSION_READERS));
} }
if (!Array.isArray(files)) files = [files];
for (const file of files) {
debug(`Reading version from ${file}`); debug(`Reading version from ${file}`);
const path = join(cwd, file); const path = join(cwd, file);
@ -58,7 +52,7 @@ export function readVersionFromFile(
if (!existsSync(path)) { if (!existsSync(path)) {
warning(`File ${path} not found`); warning(`File ${path} not found`);
continue; return;
} }
const reader = FILE_VERSION_READERS[base] ?? (() => undefined); const reader = FILE_VERSION_READERS[base] ?? (() => undefined);
@ -69,7 +63,7 @@ export function readVersionFromFile(
if (!output) { if (!output) {
warning(`Failed to read version from ${file}`); warning(`Failed to read version from ${file}`);
continue; return;
} }
} catch (error) { } catch (error) {
const { message } = error as Error; const { message } = error as Error;
@ -81,4 +75,3 @@ export function readVersionFromFile(
} }
} }
} }
}