archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 06:45:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8218228: The constructor StringBuffer(CharSequence) violates spec for negatively sized argument

Browse source 
Reviewed-by: rriggs, darcy
This commit is contained in:
Ivan Gerasimov 2019-03-01 12:47:30 -08:00
parent 2324f24c5d
commit 0052dff370
3 changed files with 38 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/java.base/share/classes/java/lang/AbstractStringBuilder.java
View file

@ -93,13 +93,16 @@ abstract class AbstractStringBuilder implements Appendable, CharSequence {
/**
* Creates an AbstractStringBuilder with the specified coder and with
* the initial capacity equal to the smaller of (capacity + addition)
* the initial capacity equal to the smaller of (length + addition)
* and Integer.MAX_VALUE.
*/
AbstractStringBuilder(byte coder, int capacity, int addition) {
AbstractStringBuilder(byte coder, int length, int addition) {
if (length < 0) {
throw new NegativeArraySizeException("Negative length: " + length);
}
this.coder = coder;
capacity = (capacity < Integer.MAX_VALUE - addition)
? capacity + addition : Integer.MAX_VALUE;
int capacity = (length < Integer.MAX_VALUE - addition)
? length + addition : Integer.MAX_VALUE;
value = (coder == LATIN1)
? new byte[capacity] : StringUTF16.newBytesFor(capacity);
}

4
src/java.base/share/classes/java/lang/StringBuffer.java
View file

@ -157,10 +157,6 @@ import jdk.internal.HotSpotIntrinsicCandidate;
* as the specified {@code CharSequence}. The initial capacity of
* the string buffer is {@code 16} plus the length of the
* {@code CharSequence} argument.
* <p>
* If the length of the specified {@code CharSequence} is
* less than or equal to zero, then an empty buffer of capacity
* {@code 16} is returned.
*
* @param seq the sequence to copy.
* @since 1.5