8207060: Memory leak when malloc fails within WITH_UNICODE_STRING block

Reviewed-by: vtewari, rriggs
This commit is contained in:
Ivan Gerasimov 2018-07-12 11:18:01 -07:00
parent 78f3c8a7d4
commit 051dfe9fb4

View file

@ -165,9 +165,6 @@ pathToNTPath(JNIEnv *env, jstring path, jboolean throwFNFE) {
pathbuf = (WCHAR*)malloc((pathlen + 6) * sizeof(WCHAR));
if (pathbuf != 0) {
wcscpy(pathbuf, ps);
} else {
JNU_ThrowOutOfMemoryError(env, "native memory allocation failed");
return NULL;
}
}
} else {
@ -191,9 +188,6 @@ pathToNTPath(JNIEnv *env, jstring path, jboolean throwFNFE) {
pathbuf = (WCHAR*)malloc((pathlen + 6) * sizeof(WCHAR));
if (pathbuf != 0) {
wcscpy(pathbuf, ps);
} else {
JNU_ThrowOutOfMemoryError(env, "native memory allocation failed");
return NULL;
}
}
}
@ -210,15 +204,11 @@ pathToNTPath(JNIEnv *env, jstring path, jboolean throwFNFE) {
pathbuf = (WCHAR*)malloc(sizeof(WCHAR));
if (pathbuf != NULL) {
pathbuf[0] = L'\0';
} else {
JNU_ThrowOutOfMemoryError(env, 0);
return NULL;
}
}
}
if (pathbuf == 0) {
JNU_ThrowOutOfMemoryError(env, 0);
return NULL;
JNU_ThrowOutOfMemoryError(env, "native memory allocation failed");
}
return pathbuf;
}