archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 14:54:52 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8185855: Debug exception stacks should be clearer

Browse source 
Reviewed-by: mullan, ascarpino
This commit is contained in:
Sean Coffey 2017-12-06 14:33:33 +00:00
parent a923e57c7b
commit 0c7be1d9e7
11 changed files with 15 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/java.base/share/classes/java/security/IdentityScope.java
View file

@ -90,8 +90,8 @@ class IdentityScope extends Identity {
try {
Class.forName(classname);
} catch (ClassNotFoundException e) {
//Security.error("unable to establish a system scope from " +
// classname);
System.err.println("unable to establish a system scope from " +
classname);
e.printStackTrace();
}
}

2
src/java.base/share/classes/java/security/Signature.java
View file

@ -1074,7 +1074,7 @@ public abstract class Signature extends SignatureSpi {
debug.println("Further warnings of this type will "
+ "be suppressed");
}
new Exception("Call trace").printStackTrace();
new Exception("Debug call trace").printStackTrace();
}
}
Exception lastException = null;

2
src/java.base/share/classes/sun/security/jca/ProviderList.java
View file

@ -308,7 +308,7 @@ public final class ProviderList {
}
if (debug != null) {
debug.println("Loading all providers");
new Exception("Call trace").printStackTrace();
new Exception("Debug Info. Call trace:").printStackTrace();
}
int n = 0;
for (int i = 0; i < configs.length; i++) {

1
src/java.base/share/classes/sun/security/pkcs/PKCS8Key.java
View file

@ -346,7 +346,6 @@ public class PKCS8Key implements PrivateKey {
}
} catch (IOException e) {
// e.printStackTrace ();
throw new InvalidKeyException("IOException : " +
e.getMessage());
}

3
src/java.base/share/classes/sun/security/provider/AuthPolicyFile.java
View file

@ -187,6 +187,7 @@ public class AuthPolicyFile extends javax.security.auth.Policy {
} catch (Exception e) {
// ignore, treat it like we have no keystore
if (debug != null) {
debug.println("Debug info only. No keystore.");
e.printStackTrace();
}
return null;
@ -261,7 +262,7 @@ public class AuthPolicyFile extends javax.security.auth.Policy {
loaded_one = true;
} catch (Exception e) {
if (debug != null) {
debug.println("error reading policy " + e);
debug.println("Debug info only. Error reading policy " + e);
e.printStackTrace();
}
// ignore that policy

12
src/java.base/share/classes/sun/security/provider/DSA.java
View file

@ -490,18 +490,6 @@ abstract class DSA extends SignatureSpi {
return printable;
}
private static void debug(Exception e) {
if (debug) {
e.printStackTrace();
}
}
private static void debug(String s) {
if (debug) {
System.err.println(s);
}
}
/**
* Standard SHA224withDSA implementation as defined in FIPS186-3.
*/

4
src/java.base/share/classes/sun/security/provider/PolicyFile.java
View file

@ -512,7 +512,8 @@ public class PolicyFile extends java.security.Policy {
}
} catch (Exception e) {
if (debug != null) {
debug.println("error reading policy "+e);
debug.println(
"Debug info only. Error reading policy " +e);
e.printStackTrace();
}
// ignore that policy
@ -559,6 +560,7 @@ public class PolicyFile extends java.security.Policy {
} catch (Exception e) {
// ignore, treat it like we have no keystore
if (debug != null) {
debug.println("Debug info only. Ignoring exception.");
e.printStackTrace();
}
}

2
src/java.base/share/classes/sun/security/util/AnchorCertificates.java
View file

@ -75,8 +75,8 @@ public class AnchorCertificates {
} catch (Exception e) {
if (debug != null) {
debug.println("Error parsing cacerts");
e.printStackTrace();
}
e.printStackTrace();
}
return null;
}

5
src/java.base/share/classes/sun/security/util/SignatureFileVerifier.java
View file

@ -386,8 +386,9 @@ public class SignatureFileVerifier {
if (e.getMessage() != null) {
debug.println(key + ": " + e.getMessage());
} else {
debug.println(key + ": " + algorithm +
" was disabled, no exception msg given.");
debug.println("Debug info only. " + key + ": " +
algorithm +
" was disabled, no exception msg given.");
e.printStackTrace();
}
}

3
src/java.base/share/classes/sun/security/x509/CertificateExtensions.java
View file

@ -124,7 +124,8 @@ public class CertificateExtensions implements CertAttrSet<Extension> {
unparseableExtensions.put(ext.getExtensionId().toString(),
new UnparseableExtension(ext, e));
if (debug != null) {
debug.println("Error parsing extension: " + ext);
debug.println("Debug info only." +
" Error parsing extension: " + ext);
e.printStackTrace();
HexDumpEncoder h = new HexDumpEncoder();
System.err.println(h.encodeBuffer(ext.getExtensionValue()));

1
src/java.base/share/classes/sun/security/x509/X509Key.java
View file

@ -392,7 +392,6 @@ public class X509Key implements PublicKey {
throw new InvalidKeyException ("excess key data");
} catch (IOException e) {
// e.printStackTrace ();
throw new InvalidKeyException("IOException: " +
e.getMessage());
}