archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 14:54:52 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8327875: ChoiceFormat should advise throwing UnsupportedOperationException for unused methods

Browse source 
Reviewed-by: naoto
This commit is contained in:
Justin Lu 2024-03-27 21:13:28 +00:00
parent e3588bba04
commit 0cb0b5db2a
1 changed files with 15 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/java.base/share/classes/java/text/ChoiceFormat.java
View file

@ -134,16 +134,6 @@ import java.util.Objects;
* Use two single quotes in a row to produce a literal single quote. For example, * Use two single quotes in a row to produce a literal single quote. For example,
* {@code new ChoiceFormat("1# ''one'' ").format(1)} returns {@code " 'one' "}. * {@code new ChoiceFormat("1# ''one'' ").format(1)} returns {@code " 'one' "}.
* *
* @apiNote A subclass could perform more consistent pattern validation by
* throwing an {@code IllegalArgumentException} for all incorrect cases.
* @implNote Given an incorrect pattern, this implementation may either
* throw an exception or succeed and discard the incorrect portion. A {@code
* NumberFormatException} is thrown if a {@code limit} can not be
* parsed as a numeric value and an {@code IllegalArgumentException} is thrown
* if a {@code SubPattern} is missing, or the intervals are not ascending.
* Discarding the incorrect portion may result in a ChoiceFormat with
* empty {@code limits} and {@code formats}.
*
* <h2>Usage Information</h2> * <h2>Usage Information</h2>
* *
* <p> * <p>
@ -224,6 +214,21 @@ import java.util.Objects;
* If multiple threads access a format concurrently, it must be synchronized * If multiple threads access a format concurrently, it must be synchronized
* externally. * externally.
* *
* @apiNote A subclass could perform more consistent pattern validation by
* throwing an {@code IllegalArgumentException} for all incorrect cases.
* See the {@code Implementation Note} for this implementation's behavior regarding
* incorrect patterns.
* <p>This class inherits instance methods from {@code NumberFormat} it does
* not utilize; a subclass could override and throw {@code
* UnsupportedOperationException} for such methods.
* @implNote Given an incorrect pattern, this implementation may either
* throw an exception or succeed and discard the incorrect portion. A {@code
* NumberFormatException} is thrown if a {@code limit} can not be
* parsed as a numeric value and an {@code IllegalArgumentException} is thrown
* if a {@code SubPattern} is missing, or the intervals are not ascending.
* Discarding the incorrect portion may result in a ChoiceFormat with
* empty {@code limits} and {@code formats}.
*
* *
* @see DecimalFormat * @see DecimalFormat
* @see MessageFormat * @see MessageFormat