archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 07:14:30 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8302325: Wrong comment in java.base/share/native/libjimage/imageFile.hpp

Browse source 
Reviewed-by: alanb, jlaskey
This commit is contained in:
Severin Gehwolf 2023-02-15 09:54:47 +00:00
parent 33bec20710
commit 11194e8b82
3 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/java.base/share/native/libjimage/imageFile.cpp
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2015, 2023, Oracle and/or its affiliates. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions

14
src/java.base/share/native/libjimage/imageFile.hpp
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2015, 2023, Oracle and/or its affiliates. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@ -203,8 +203,8 @@ public:
// 'length' less 1 (lower 3 bits of header) of bytes that follow containing the
// attribute value. Attribute values present as most significant byte first.
//
// Ex. Container offset (ATTRIBUTE_OFFSET) 0x33562 would be represented as 0x22
// (kind = 4, length = 3), 0x03, 0x35, 0x62.
// Ex. Container offset (ATTRIBUTE_OFFSET) 0x33562 would be represented as 0x2A
// (kind = 5, length = 3), 0x03, 0x35, 0x62.
//
// An attribute stream is terminated with a header kind of ATTRIBUTE_END (header
// byte of zero.)
@ -214,10 +214,10 @@ public:
// direct indexing. Unspecified values default to zero.
//
// Notes:
// - Even though ATTRIBUTE_END is used to mark the end of the attribute stream,
// streams will contain zero byte values to represent lesser significant bits.
// Thus, detecting a zero byte is not sufficient to detect the end of an attribute
// stream.
// - Even though ATTRIBUTE_END (which might be encoded with a zero byte) is used to
// mark the end of the attribute stream, streams will contain zero byte values
// in the non-header portion of the attribute data. Thus, detecting a zero byte
// is not sufficient to detect the end of an attribute stream.
// - ATTRIBUTE_OFFSET represents the number of bytes from the beginning of the region
// storing the resources. Thus, in an image this represents the number of bytes
// after the index.