archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-18 01:54:47 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8194489: Incorrect size computation at BandedSampleModel.createDataBuffer()

Browse source 
Reviewed-by: bpb, jdv
This commit is contained in:
Prahalad Narayanan 2018-01-16 10:49:49 +05:30 • committed by Prahalad Kumar Narayanan
parent 0255b84ad3
commit 15ecb4705f
2 changed files with 166 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

28
src/java.desktop/share/classes/java/awt/image/BandedSampleModel.java
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 1997, 2013, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1997, 2018, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -185,7 +185,33 @@ public final class BandedSampleModel extends ComponentSampleModel
public DataBuffer createDataBuffer() {
DataBuffer dataBuffer = null;
// The minimum size required to store samples of one band
int size = scanlineStride * height;
if (numBanks == 1) {
/*
* The sample model contains a single bank of data buffer. Hence
* we need to compute the size required to store samples of all
* bands including the respective offsets.
*/
int sizePerBand = size;
size += bandOffsets[0];
for (int index = 1; index < bandOffsets.length; index++) {
size += (bandOffsets[index] - size) + sizePerBand;
}
} else {
/*
* The sample model contains multiple banks of data buffer where
* each bank would correspond to a particular band. Hence we need
* to compute only the additional space required for band offsets.
*/
int maxBandOffset = bandOffsets[0];
for (int index = 1; index < bandOffsets.length; index++) {
maxBandOffset = Math.max(maxBandOffset, bandOffsets[index]);
}
size += maxBandOffset;
}
switch (dataType) {
case DataBuffer.TYPE_BYTE:
dataBuffer = new DataBufferByte(size, numBanks);