archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-17 17:44:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8224119: Safepoint cleanup logging logs times for things it doesn't do

Browse source 
Test condition before reporting times for cleanup actions.

Reviewed-by: rehn, hseigel
This commit is contained in:
Coleen Phillimore 2019-05-21 09:53:16 -04:00
parent b730805159
commit 168e5cbf66
4 changed files with 29 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/hotspot/share/runtime/safepoint.cpp
View file

@ -24,6 +24,7 @@
#include "precompiled.hpp"
#include "classfile/classLoaderDataGraph.inline.hpp"
#include "classfile/dictionary.hpp"
#include "classfile/stringTable.hpp"
#include "classfile/symbolTable.hpp"
#include "classfile/systemDictionary.hpp"
@ -610,23 +611,27 @@ public:
}
if (_subtasks.try_claim_task(SafepointSynchronize::SAFEPOINT_CLEANUP_CLD_PURGE)) {
// CMS delays purging the CLDG until the beginning of the next safepoint and to
// make sure concurrent sweep is done
const char* name = "purging class loader data graph";
EventSafepointCleanupTask event;
TraceTime timer(name, TRACETIME_LOG(Info, safepoint, cleanup));
ClassLoaderDataGraph::purge_if_needed();
if (ClassLoaderDataGraph::should_purge_and_reset()) {
// CMS delays purging the CLDG until the beginning of the next safepoint and to
// make sure concurrent sweep is done
const char* name = "purging class loader data graph";
EventSafepointCleanupTask event;
TraceTime timer(name, TRACETIME_LOG(Info, safepoint, cleanup));
ClassLoaderDataGraph::purge();
post_safepoint_cleanup_task_event(event, safepoint_id, name);
post_safepoint_cleanup_task_event(event, safepoint_id, name);
}
}
if (_subtasks.try_claim_task(SafepointSynchronize::SAFEPOINT_CLEANUP_SYSTEM_DICTIONARY_RESIZE)) {
const char* name = "resizing system dictionaries";
EventSafepointCleanupTask event;
TraceTime timer(name, TRACETIME_LOG(Info, safepoint, cleanup));
ClassLoaderDataGraph::resize_if_needed();
if (Dictionary::does_any_dictionary_needs_resizing()) {
const char* name = "resizing system dictionaries";
EventSafepointCleanupTask event;
TraceTime timer(name, TRACETIME_LOG(Info, safepoint, cleanup));
ClassLoaderDataGraph::resize_dictionaries();
post_safepoint_cleanup_task_event(event, safepoint_id, name);
post_safepoint_cleanup_task_event(event, safepoint_id, name);
}
}
_subtasks.all_tasks_completed(_num_workers);