archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 15:24:43 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8296142: CertAttrSet::(getName|getElements|delete) are mostly useless

Browse source 
Reviewed-by: mullan
This commit is contained in:
Weijun Wang 2022-11-02 14:40:47 +00:00
parent 6626a29a74
commit 16a041a67a
41 changed files with 60 additions and 1162 deletions
Download patch file Download diff file Expand all files Collapse all files

48
src/java.base/share/classes/sun/security/x509/KeyUsageExtension.java
View file

@ -26,7 +26,6 @@
package sun.security.x509;
import java.io.IOException;
import java.util.Enumeration;
import sun.security.util.*;
@ -242,34 +241,6 @@ implements CertAttrSet<String> {
}
}
/**
* Delete the attribute value.
*/
public void delete(String name) throws IOException {
if (name.equalsIgnoreCase(DIGITAL_SIGNATURE)) {
set(0,false);
} else if (name.equalsIgnoreCase(NON_REPUDIATION)) {
set(1,false);
} else if (name.equalsIgnoreCase(KEY_ENCIPHERMENT)) {
set(2,false);
} else if (name.equalsIgnoreCase(DATA_ENCIPHERMENT)) {
set(3,false);
} else if (name.equalsIgnoreCase(KEY_AGREEMENT)) {
set(4,false);
} else if (name.equalsIgnoreCase(KEY_CERTSIGN)) {
set(5,false);
} else if (name.equalsIgnoreCase(CRL_SIGN)) {
set(6,false);
} else if (name.equalsIgnoreCase(ENCIPHER_ONLY)) {
set(7,false);
} else if (name.equalsIgnoreCase(DECIPHER_ONLY)) {
set(8,false);
} else {
throw new IOException("Attribute name not recognized by"
+ " CertAttrSet:KeyUsage.");
}
encodeThis();
}
/**
* Returns a printable representation of the KeyUsage.
@ -327,24 +298,6 @@ implements CertAttrSet<String> {
super.encode(out);
}
/**
* Return an enumeration of names of attributes existing within this
* attribute.
*/
public Enumeration<String> getElements() {
AttributeNameEnumeration elements = new AttributeNameEnumeration();
elements.addElement(DIGITAL_SIGNATURE);
elements.addElement(NON_REPUDIATION);
elements.addElement(KEY_ENCIPHERMENT);
elements.addElement(DATA_ENCIPHERMENT);
elements.addElement(KEY_AGREEMENT);
elements.addElement(KEY_CERTSIGN);
elements.addElement(CRL_SIGN);
elements.addElement(ENCIPHER_ONLY);
elements.addElement(DECIPHER_ONLY);
return (elements.elements());
}
public boolean[] getBits() {
@ -354,6 +307,7 @@ implements CertAttrSet<String> {
/**
* Return the name of this attribute.
*/
@Override
public String getName() {
return (NAME);
}