8189963: Remove version of FileChannelImpl::open without the 'direct' parameter

Remove old version of FileChannelImpl::open and update call sites

Reviewed-by: rriggs

src/java.base/share/classes/java/io/FileInputStream.java

@@ -385,7 +385,8 @@ class FileInputStream extends InputStream
             synchronized (this) {
                 fc = this.channel;
                 if (fc == null) {
-                    this.channel = fc = FileChannelImpl.open(fd, path, true, false, this);
+                    this.channel = fc = FileChannelImpl.open(fd, path, true,
+                        false, false, this);
                     if (closed) {
                         try {
                             // possible race with close(), benign since

src/java.base/share/classes/java/io/FileOutputStream.java

@@ -410,7 +410,8 @@ class FileOutputStream extends OutputStream
             synchronized (this) {
                 fc = this.channel;
                 if (fc == null) {
-                    this.channel = fc = FileChannelImpl.open(fd, path, false, true, this);
+                    this.channel = fc = FileChannelImpl.open(fd, path, false,
+                        true, false, this);
                     if (closed) {
                         try {
                             // possible race with close(), benign since

src/java.base/share/classes/java/io/RandomAccessFile.java

@@ -298,7 +298,8 @@ public class RandomAccessFile implements DataOutput, DataInput, Closeable {
             synchronized (this) {
                 fc = this.channel;
                 if (fc == null) {
-                    this.channel = fc = FileChannelImpl.open(fd, path, true, rw, this);
+                    this.channel = fc = FileChannelImpl.open(fd, path, true,
+                        rw, false, this);
                     if (closed.get()) {
                         try {
                             fc.close();

src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java

@@ -140,13 +140,6 @@ public class FileChannelImpl
 
     // Used by FileInputStream.getChannel(), FileOutputStream.getChannel
     // and RandomAccessFile.getChannel()
-    public static FileChannel open(FileDescriptor fd, String path,
-                                   boolean readable, boolean writable,
-                                   Object parent)
-    {
-        return new FileChannelImpl(fd, path, readable, writable, false, parent);
-    }
-
     public static FileChannel open(FileDescriptor fd, String path,
                                    boolean readable, boolean writable,
                                    boolean direct, Object parent)

src/java.base/unix/classes/sun/nio/fs/UnixChannelFactory.java

@@ -110,7 +110,7 @@ class UnixChannelFactory {
     static FileChannel newFileChannel(int fd, String path, boolean reading, boolean writing) {
         FileDescriptor fdObj = new FileDescriptor();
         fdAccess.set(fdObj, fd);
-        return FileChannelImpl.open(fdObj, path, reading, writing, null);
+        return FileChannelImpl.open(fdObj, path, reading, writing, false, null);
     }
 
     /**