archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 14:54:52 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8221723: Avoid storing zero to String.hash

Browse source 
Reviewed-by: shade, prappo, jiangli
This commit is contained in:
Claes Redestad 2019-04-02 11:24:40 +02:00
parent 6bce53795b
commit 1908897b93
2 changed files with 20 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/java.base/share/classes/java/lang/String.java
View file

@ -1510,8 +1510,14 @@ public final class String
public int hashCode() {
int h = hash;
if (h == 0 && value.length > 0) {
hash = h = isLatin1() ? StringLatin1.hashCode(value)
: StringUTF16.hashCode(value);
h = isLatin1() ? StringLatin1.hashCode(value)
: StringUTF16.hashCode(value);
// Avoid issuing a store if the calculated value is also zero:
// in addition to a minor performance benefit, this allows storing
// Strings with zero hash code in read-only memory.
if (h != 0) {
hash = h;
}
}
return h;
}