8343437: ClassDesc.of incorrectly permitting empty names

Reviewed-by: mchung
This commit is contained in:
Chen Liang 2024-11-04 13:24:09 +00:00
parent 895a7b64f0
commit 1f7d524fd3
5 changed files with 80 additions and 60 deletions

View file

@ -120,7 +120,7 @@ public sealed interface ClassDesc
* not in the correct format
*/
static ClassDesc of(String packageName, String className) {
validateBinaryClassName(packageName);
validateBinaryPackageName(packageName);
validateMemberName(className, false);
if (packageName.isEmpty()) {
return internalNameToDesc(className);

View file

@ -55,7 +55,7 @@ public sealed interface PackageDesc
* @see PackageDesc#ofInternalName(String)
*/
static PackageDesc of(String name) {
ConstantUtils.validateBinaryPackageName(requireNonNull(name));
ConstantUtils.validateBinaryPackageName(name);
return new PackageDescImpl(ConstantUtils.binaryToInternal(name));
}
@ -75,7 +75,7 @@ public sealed interface PackageDesc
* @see PackageDesc#of(String)
*/
static PackageDesc ofInternalName(String name) {
ConstantUtils.validateInternalPackageName(requireNonNull(name));
ConstantUtils.validateInternalPackageName(name);
return new PackageDescImpl(name);
}