archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-15 13:49:42 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8362530: VM crash with -XX:+PrintTieredEvents when collecting AOT profiling

Browse source 
Reviewed-by: chagedorn, kvn
This commit is contained in:
Igor Veresov 2025-08-14 16:59:05 +00:00
parent b0f98df75a
commit 26ccb3cef1
3 changed files with 75 additions and 57 deletions
Download patch file Download diff file Expand all files Collapse all files

107
src/hotspot/share/compiler/compilationPolicy.cpp
View file

@ -404,7 +404,7 @@ double CompilationPolicy::threshold_scale(CompLevel level, int feedback_k) {
return 1; return 1;
} }
void CompilationPolicy::print_counters(const char* prefix, Method* m) { void CompilationPolicy::print_counters_on(outputStream* st, const char* prefix, Method* m) {
int invocation_count = m->invocation_count(); int invocation_count = m->invocation_count();
int backedge_count = m->backedge_count(); int backedge_count = m->backedge_count();
MethodData* mdh = m->method_data(); MethodData* mdh = m->method_data();
@ -416,133 +416,140 @@ void CompilationPolicy::print_counters(const char* prefix, Method* m) {
mdo_invocations_start = mdh->invocation_count_start(); mdo_invocations_start = mdh->invocation_count_start();
mdo_backedges_start = mdh->backedge_count_start(); mdo_backedges_start = mdh->backedge_count_start();
} }
tty->print(" %stotal=%d,%d %smdo=%d(%d),%d(%d)", prefix, st->print(" %stotal=%d,%d %smdo=%d(%d),%d(%d)", prefix,
invocation_count, backedge_count, prefix, invocation_count, backedge_count, prefix,
mdo_invocations, mdo_invocations_start, mdo_invocations, mdo_invocations_start,
mdo_backedges, mdo_backedges_start); mdo_backedges, mdo_backedges_start);
tty->print(" %smax levels=%d,%d", prefix, st->print(" %smax levels=%d,%d", prefix, m->highest_comp_level(), m->highest_osr_comp_level());
m->highest_comp_level(), m->highest_osr_comp_level());
} }
void CompilationPolicy::print_training_data(const char* prefix, Method* method) { void CompilationPolicy::print_training_data_on(outputStream* st, const char* prefix, Method* method) {
methodHandle m(Thread::current(), method); methodHandle m(Thread::current(), method);
tty->print(" %smtd: ", prefix); st->print(" %smtd: ", prefix);
MethodTrainingData* mtd = MethodTrainingData::find(m); MethodTrainingData* mtd = MethodTrainingData::find(m);
if (mtd == nullptr) { if (mtd == nullptr) {
tty->print("null"); st->print("null");
} else { } else {
MethodData* md = mtd->final_profile(); MethodData* md = mtd->final_profile();
tty->print("mdo="); st->print("mdo=");
if (md == nullptr) { if (md == nullptr) {
tty->print("null"); st->print("null");
} else { } else {
int mdo_invocations = md->invocation_count(); int mdo_invocations = md->invocation_count();
int mdo_backedges = md->backedge_count(); int mdo_backedges = md->backedge_count();
int mdo_invocations_start = md->invocation_count_start(); int mdo_invocations_start = md->invocation_count_start();
int mdo_backedges_start = md->backedge_count_start(); int mdo_backedges_start = md->backedge_count_start();
tty->print("%d(%d), %d(%d)", mdo_invocations, mdo_invocations_start, mdo_backedges, mdo_backedges_start); st->print("%d(%d), %d(%d)", mdo_invocations, mdo_invocations_start, mdo_backedges, mdo_backedges_start);
} }
CompileTrainingData* ctd = mtd->last_toplevel_compile(CompLevel_full_optimization); CompileTrainingData* ctd = mtd->last_toplevel_compile(CompLevel_full_optimization);
tty->print(", deps="); st->print(", deps=");
if (ctd == nullptr) { if (ctd == nullptr) {
tty->print("null"); st->print("null");
} else { } else {
tty->print("%d", ctd->init_deps_left()); st->print("%d", ctd->init_deps_left());
} }
} }
} }
// Print an event. // Print an event.
void CompilationPolicy::print_event(EventType type, Method* m, Method* im, int bci, CompLevel level) { void CompilationPolicy::print_event_on(outputStream *st, EventType type, Method* m, Method* im, int bci, CompLevel level) {
bool inlinee_event = m != im; bool inlinee_event = m != im;
ttyLocker tty_lock; st->print("%lf: [", os::elapsedTime());
tty->print("%lf: [", os::elapsedTime());
switch(type) { switch(type) {
case CALL: case CALL:
tty->print("call"); st->print("call");
break; break;
case LOOP: case LOOP:
tty->print("loop"); st->print("loop");
break; break;
case COMPILE: case COMPILE:
tty->print("compile"); st->print("compile");
break; break;
case FORCE_COMPILE: case FORCE_COMPILE:
tty->print("force-compile"); st->print("force-compile");
break; break;
case REMOVE_FROM_QUEUE: case REMOVE_FROM_QUEUE:
tty->print("remove-from-queue"); st->print("remove-from-queue");
break; break;
case UPDATE_IN_QUEUE: case UPDATE_IN_QUEUE:
tty->print("update-in-queue"); st->print("update-in-queue");
break; break;
case REPROFILE: case REPROFILE:
tty->print("reprofile"); st->print("reprofile");
break; break;
case MAKE_NOT_ENTRANT: case MAKE_NOT_ENTRANT:
tty->print("make-not-entrant"); st->print("make-not-entrant");
break; break;
default: default:
tty->print("unknown"); st->print("unknown");
} }
tty->print(" level=%d ", level); st->print(" level=%d ", level);
ResourceMark rm; ResourceMark rm;
char *method_name = m->name_and_sig_as_C_string(); char *method_name = m->name_and_sig_as_C_string();
tty->print("[%s", method_name); st->print("[%s", method_name);
if (inlinee_event) { if (inlinee_event) {
char *inlinee_name = im->name_and_sig_as_C_string(); char *inlinee_name = im->name_and_sig_as_C_string();
tty->print(" [%s]] ", inlinee_name); st->print(" [%s]] ", inlinee_name);
} }
else tty->print("] "); else st->print("] ");
tty->print("@%d queues=%d,%d", bci, CompileBroker::queue_size(CompLevel_full_profile), st->print("@%d queues=%d,%d", bci, CompileBroker::queue_size(CompLevel_full_profile),
CompileBroker::queue_size(CompLevel_full_optimization)); CompileBroker::queue_size(CompLevel_full_optimization));
tty->print(" rate="); st->print(" rate=");
if (m->prev_time() == 0) tty->print("n/a"); if (m->prev_time() == 0) st->print("n/a");
else tty->print("%f", m->rate()); else st->print("%f", m->rate());
tty->print(" k=%.2lf,%.2lf", threshold_scale(CompLevel_full_profile, Tier3LoadFeedback), st->print(" k=%.2lf,%.2lf", threshold_scale(CompLevel_full_profile, Tier3LoadFeedback),
threshold_scale(CompLevel_full_optimization, Tier4LoadFeedback)); threshold_scale(CompLevel_full_optimization, Tier4LoadFeedback));
if (type != COMPILE) { if (type != COMPILE) {
print_counters("", m); print_counters_on(st, "", m);
if (inlinee_event) { if (inlinee_event) {
print_counters("inlinee ", im); print_counters_on(st, "inlinee ", im);
} }
tty->print(" compilable="); st->print(" compilable=");
bool need_comma = false; bool need_comma = false;
if (!m->is_not_compilable(CompLevel_full_profile)) { if (!m->is_not_compilable(CompLevel_full_profile)) {
tty->print("c1"); st->print("c1");
need_comma = true; need_comma = true;
} }
if (!m->is_not_osr_compilable(CompLevel_full_profile)) { if (!m->is_not_osr_compilable(CompLevel_full_profile)) {
if (need_comma) tty->print(","); if (need_comma) st->print(",");
tty->print("c1-osr"); st->print("c1-osr");
need_comma = true; need_comma = true;
} }
if (!m->is_not_compilable(CompLevel_full_optimization)) { if (!m->is_not_compilable(CompLevel_full_optimization)) {
if (need_comma) tty->print(","); if (need_comma) st->print(",");
tty->print("c2"); st->print("c2");
need_comma = true; need_comma = true;
} }
if (!m->is_not_osr_compilable(CompLevel_full_optimization)) { if (!m->is_not_osr_compilable(CompLevel_full_optimization)) {
if (need_comma) tty->print(","); if (need_comma) st->print(",");
tty->print("c2-osr"); st->print("c2-osr");
} }
tty->print(" status="); st->print(" status=");
if (m->queued_for_compilation()) { if (m->queued_for_compilation()) {
tty->print("in-queue"); st->print("in-queue");
} else tty->print("idle"); } else st->print("idle");
print_training_data("", m);
print_training_data_on(st, "", m);
if (inlinee_event) { if (inlinee_event) {
print_training_data("inlinee ", im); print_training_data_on(st, "inlinee ", im);
} }
} }
tty->print_cr("]"); st->print_cr("]");
}
void CompilationPolicy::print_event(EventType type, Method* m, Method* im, int bci, CompLevel level) {
stringStream s;
print_event_on(&s, type, m, im, bci, level);
ResourceMark rm;
tty->print("%s", s.as_string());
} }
void CompilationPolicy::initialize() { void CompilationPolicy::initialize() {

5
src/hotspot/share/compiler/compilationPolicy.hpp
View file

@ -287,8 +287,8 @@ class CompilationPolicy : AllStatic {
// loop_event checks if a method should be OSR compiled at a different // loop_event checks if a method should be OSR compiled at a different
// level. // level.
static CompLevel loop_event(const methodHandle& method, CompLevel cur_level, JavaThread* THREAD); static CompLevel loop_event(const methodHandle& method, CompLevel cur_level, JavaThread* THREAD);
static void print_counters(const char* prefix, Method* m); static void print_counters_on(outputStream* st, const char* prefix, Method* m);
static void print_training_data(const char* prefix, Method* method); static void print_training_data_on(outputStream* st, const char* prefix, Method* method);
// Has a method been long around? // Has a method been long around?
// We don't remove old methods from the compile queue even if they have // We don't remove old methods from the compile queue even if they have
// very low activity (see select_task()). // very low activity (see select_task()).
@ -318,6 +318,7 @@ class CompilationPolicy : AllStatic {
static void set_c2_count(int x) { _c2_count = x; } static void set_c2_count(int x) { _c2_count = x; }
enum EventType { CALL, LOOP, COMPILE, FORCE_COMPILE, FORCE_RECOMPILE, REMOVE_FROM_QUEUE, UPDATE_IN_QUEUE, REPROFILE, MAKE_NOT_ENTRANT }; enum EventType { CALL, LOOP, COMPILE, FORCE_COMPILE, FORCE_RECOMPILE, REMOVE_FROM_QUEUE, UPDATE_IN_QUEUE, REPROFILE, MAKE_NOT_ENTRANT };
static void print_event_on(outputStream *st, EventType type, Method* m, Method* im, int bci, CompLevel level);
static void print_event(EventType type, Method* m, Method* im, int bci, CompLevel level); static void print_event(EventType type, Method* m, Method* im, int bci, CompLevel level);
// Check if the method can be compiled, change level if necessary // Check if the method can be compiled, change level if necessary
static void compile(const methodHandle& mh, int bci, CompLevel level, TRAPS); static void compile(const methodHandle& mh, int bci, CompLevel level, TRAPS);

10
test/hotspot/jtreg/runtime/cds/appcds/aotFlags/AOTFlags.java
View file

@ -257,6 +257,16 @@ public class AOTFlags {
out.shouldContain("AOTCache creation is complete: hello.aot"); out.shouldContain("AOTCache creation is complete: hello.aot");
out.shouldMatch("Picked up JAVA_TOOL_OPTIONS:.* -Dmy.prop=My' 'string' '-Xshare:off' 'here"); out.shouldMatch("Picked up JAVA_TOOL_OPTIONS:.* -Dmy.prop=My' 'string' '-Xshare:off' 'here");
out.shouldHaveExitValue(0); out.shouldHaveExitValue(0);
// Training run with -XX:+PrintTieredEvents (see JDK-8362530).
printTestCase("Training run with -XX:+PrintTieredEvents");
pb = ProcessTools.createLimitedTestJavaProcessBuilder(
"-XX:AOTMode=record",
"-XX:+PrintTieredEvents",
"-XX:AOTConfiguration=" + aotConfigFile,
"-cp", appJar, helloClass);
out = CDSTestUtils.executeAndLog(pb, "train-with-tiered-events");
out.shouldHaveExitValue(0);
} }
static void negativeTests() throws Exception { static void negativeTests() throws Exception {