archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 23:34:52 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8064865: Remove the debug funciontality RotateCMSCollectionTypes for CMS

Browse source 
Reviewed-by: jmasa, kbarrett, ysr
This commit is contained in:
Bengt Rutisson 2014-11-18 10:39:16 +01:00
parent 4b60638d85
commit 2da855a259
3 changed files with 0 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

26
hotspot/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
View file

@ -192,7 +192,6 @@ ConcurrentMarkSweepGeneration::ConcurrentMarkSweepGeneration(
FreeBlockDictionary<FreeChunk>::DictionaryChoice dictionaryChoice) : FreeBlockDictionary<FreeChunk>::DictionaryChoice dictionaryChoice) :
CardGeneration(rs, initial_byte_size, level, ct), CardGeneration(rs, initial_byte_size, level, ct),
_dilatation_factor(((double)MinChunkSize)/((double)(CollectedHeap::min_fill_size()))), _dilatation_factor(((double)MinChunkSize)/((double)(CollectedHeap::min_fill_size()))),
_debug_concurrent_cycle(true),
_did_compact(false) _did_compact(false)
{ {
HeapWord* bottom = (HeapWord*) _virtual_space.low(); HeapWord* bottom = (HeapWord*) _virtual_space.low();
@ -1245,14 +1244,6 @@ bool CMSCollector::shouldConcurrentCollect() {
return true; return true;
} }
// For debugging purposes, change the type of collection.
// Rotate between concurrent and stop-the-world full GCs.
NOT_PRODUCT(
if (RotateCMSCollectionTypes) {
return _cmsGen->debug_concurrent_cycle();
}
)
FreelistLocker x(this); FreelistLocker x(this);
// ------------------------------------------------------------------ // ------------------------------------------------------------------
// Print out lots of information which affects the initiation of // Print out lots of information which affects the initiation of
@ -5830,17 +5821,6 @@ void ConcurrentMarkSweepGeneration::update_gc_stats(int current_level,
} }
} }
void ConcurrentMarkSweepGeneration::rotate_debug_collection_type() {
if (PrintGCDetails && Verbose) {
if (_debug_concurrent_cycle) {
gclog_or_tty->print_cr("Rotate from concurrent to STW collections");
} else {
gclog_or_tty->print_cr("Rotate from STW to concurrent collections");
}
}
_debug_concurrent_cycle = !_debug_concurrent_cycle;
}
void CMSCollector::sweepWork(ConcurrentMarkSweepGeneration* gen) { void CMSCollector::sweepWork(ConcurrentMarkSweepGeneration* gen) {
// We iterate over the space(s) underlying this generation, // We iterate over the space(s) underlying this generation,
// checking the mark bit map to see if the bits corresponding // checking the mark bit map to see if the bits corresponding
@ -5961,12 +5941,6 @@ void CMSCollector::reset(bool concurrent) {
_collectorState = Idling; _collectorState = Idling;
} }
NOT_PRODUCT(
if (RotateCMSCollectionTypes) {
_cmsGen->rotate_debug_collection_type();
}
)
register_gc_end(); register_gc_end();
} }

5
hotspot/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp
View file

@ -1040,8 +1040,6 @@ class ConcurrentMarkSweepGeneration: public CardGeneration {
// In support of MinChunkSize being larger than min object size // In support of MinChunkSize being larger than min object size
const double _dilatation_factor; const double _dilatation_factor;
bool _debug_concurrent_cycle;
// True if a compacting collection was done. // True if a compacting collection was done.
bool _did_compact; bool _did_compact;
bool did_compact() { return _did_compact; } bool did_compact() { return _did_compact; }
@ -1268,9 +1266,6 @@ class ConcurrentMarkSweepGeneration: public CardGeneration {
// Resize the generation after a non-compacting // Resize the generation after a non-compacting
// collection. // collection.
void compute_new_size_free_list(); void compute_new_size_free_list();
bool debug_concurrent_cycle() { return _debug_concurrent_cycle; }
void rotate_debug_collection_type();
}; };
// //

3
hotspot/src/share/vm/runtime/globals.hpp
View file

@ -1523,9 +1523,6 @@ class CommandLineFlags {
develop(bool, UseAsyncConcMarkSweepGC, true, \ develop(bool, UseAsyncConcMarkSweepGC, true, \
"Use Asynchronous Concurrent Mark-Sweep GC in the old generation")\ "Use Asynchronous Concurrent Mark-Sweep GC in the old generation")\
\ \
develop(bool, RotateCMSCollectionTypes, false, \
"Rotate the CMS collections among concurrent and STW") \
\
product(bool, UseCMSBestFit, true, \ product(bool, UseCMSBestFit, true, \
"Use CMS best fit allocation strategy") \ "Use CMS best fit allocation strategy") \
\ \