archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 14:54:52 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

7172640: C2: instrinsic implementations in LibraryCallKit should use argument() instead of pop()

Browse source 
Reviewed-by: kvn, jrose
This commit is contained in:
Christian Thalinger 2012-11-26 17:25:11 -08:00
parent 7f0d3fe5e7
commit 31411dbc32
16 changed files with 774 additions and 1067 deletions
Download patch file Download diff file Expand all files Collapse all files

12
hotspot/src/share/vm/opto/parseHelper.cpp
View file

@ -84,7 +84,7 @@ void Parse::do_checkcast() {
C->log()->identify(tp->klass()));
}
}
do_null_assert(obj, T_OBJECT);
null_assert(obj);
assert( stopped() || _gvn.type(peek())->higher_equal(TypePtr::NULL_PTR), "what's left behind is null" );
if (!stopped()) {
profile_null_checkcast();
@ -116,7 +116,7 @@ void Parse::do_instanceof() {
C->log()->elem("assert_null reason='instanceof' klass='%d'",
C->log()->identify(klass));
}
do_null_assert(peek(), T_OBJECT);
null_assert(peek());
assert( stopped() || _gvn.type(peek())->higher_equal(TypePtr::NULL_PTR), "what's left behind is null" );
if (!stopped()) {
// The object is now known to be null.
@ -139,10 +139,10 @@ void Parse::do_instanceof() {
// pull array from stack and check that the store is valid
void Parse::array_store_check() {
// Shorthand access to array store elements
Node *obj = stack(_sp-1);
Node *idx = stack(_sp-2);
Node *ary = stack(_sp-3);
// Shorthand access to array store elements without popping them.
Node *obj = peek(0);
Node *idx = peek(1);
Node *ary = peek(2);
if (_gvn.type(obj) == TypePtr::NULL_PTR) {
// There's never a type check on null values.