archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-26 22:34:27 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8138707: TestPromotionEventWithParallelScavenge.java crashes using undefined GC id

Browse source 
Reviewed-by: mgerdin, jwilhelm
This commit is contained in:
Bengt Rutisson 2015-10-06 14:27:03 +02:00
parent 48bbdafeed
commit 3289307dbe
3 changed files with 25 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

17
hotspot/src/share/vm/gc/parallel/gcTaskManager.hpp
View file

@ -68,13 +68,16 @@ public:
};
private:
// Instance state.
const Kind::kind _kind; // For runtime type checking.
const uint _affinity; // Which worker should run task.
Kind::kind _kind; // For runtime type checking.
uint _affinity; // Which worker should run task.
GCTask* _newer; // Tasks are on doubly-linked ...
GCTask* _older; // ... lists.
uint _gc_id; // GC Id to use for the thread that executes this task
public:
virtual char* name() { return (char *)"task"; }
uint gc_id() { return _gc_id; }
// Abstract do_it method
virtual void do_it(GCTaskManager* manager, uint which) = 0;
// Accessors
@ -116,17 +119,14 @@ protected:
GCTask();
// A GCTask of a particular kind, usually barrier or noop.
GCTask(Kind::kind kind);
// An ordinary GCTask with an affinity.
GCTask(uint affinity);
// A GCTask of a particular kind, with and affinity.
GCTask(Kind::kind kind, uint affinity);
GCTask(Kind::kind kind, uint gc_id);
// We want a virtual destructor because virtual methods,
// but since ResourceObj's don't have their destructors
// called, we don't have one at all. Instead we have
// this method, which gets called by subclasses to clean up.
virtual void destruct();
// Methods.
void initialize();
void initialize(Kind::kind kind, uint gc_id);
};
// A doubly-linked list of GCTasks.
@ -567,8 +567,7 @@ public:
}
protected:
// Constructor.
NoopGCTask() :
GCTask(GCTask::Kind::noop_task) { }
NoopGCTask();
// Destructor-like method.
void destruct();
};