archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-20 02:54:35 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8173848: realpath is unsafe

Browse source 
Fix occurrences of realpath in hotspot to use safe POSIX.1-2008 form.

Reviewed-by: dsamersoff, dholmes, clanger
This commit is contained in:
Thomas Stuefe 2017-03-13 20:23:11 +01:00
parent 4b9562288f
commit 35d5d1c53d
6 changed files with 69 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

12
hotspot/src/os/solaris/vm/os_solaris.cpp
View file

@ -2034,7 +2034,9 @@ void os::jvm_path(char *buf, jint buflen) {
int ret = dladdr(CAST_FROM_FN_PTR(void *, os::jvm_path), &dlinfo);
assert(ret != 0, "cannot locate libjvm");
if (ret != 0 && dlinfo.dli_fname != NULL) {
realpath((char *)dlinfo.dli_fname, buf);
if (os::Posix::realpath((char *)dlinfo.dli_fname, buf, buflen) == NULL) {
return;
}
} else {
buf[0] = '\0';
return;
@ -2065,7 +2067,9 @@ void os::jvm_path(char *buf, jint buflen) {
p = strrchr(buf, '/');
assert(strstr(p, "/libjvm") == p, "invalid library name");
realpath(java_home_var, buf);
if (os::Posix::realpath(java_home_var, buf, buflen) == NULL) {
return;
}
// determine if this is a legacy image or modules image
// modules image doesn't have "jre" subdirectory
len = strlen(buf);
@ -2082,7 +2086,9 @@ void os::jvm_path(char *buf, jint buflen) {
snprintf(buf + len, buflen-len, "/hotspot/libjvm.so");
} else {
// Go back to path of .so
realpath((char *)dlinfo.dli_fname, buf);
if (os::Posix::realpath((char *)dlinfo.dli_fname, buf, buflen) == NULL) {
return;
}
}
}
}