archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 14:54:52 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8334755: Asymptotically faster implementation of square root algorithm

Browse source 
Reviewed-by: rgiulietti
This commit is contained in:
fabioromano1 2024-08-03 13:08:54 +00:00 • committed by Raffaello Giulietti
parent 34edc7358f
commit 367e0a6556
4 changed files with 390 additions and 85 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/java.base/share/classes/java/math/BigInteger.java
View file

@ -2723,7 +2723,7 @@ public class BigInteger extends Number implements Comparable<BigInteger> {
throw new ArithmeticException("Negative BigInteger");
}
return new MutableBigInteger(this.mag).sqrt().toBigInteger();
return new MutableBigInteger(this.mag).sqrtRem(false)[0].toBigInteger();
}
/**
@ -2742,10 +2742,12 @@ public class BigInteger extends Number implements Comparable<BigInteger> {
* @since 9
*/
public BigInteger[] sqrtAndRemainder() {
BigInteger s = sqrt();
BigInteger r = this.subtract(s.square());
assert r.compareTo(BigInteger.ZERO) >= 0;
return new BigInteger[] {s, r};
if (this.signum < 0) {
throw new ArithmeticException("Negative BigInteger");
}
MutableBigInteger[] sqrtRem = new MutableBigInteger(this.mag).sqrtRem(true);
return new BigInteger[] { sqrtRem[0].toBigInteger(), sqrtRem[1].toBigInteger() };
}
/**