archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 15:24:43 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8285516: clearPassword should be called in a finally try block

Browse source 
Reviewed-by: mullan, hchao
This commit is contained in:
Xue-Lei Andrew Fan 2022-05-09 14:13:50 +00:00
parent b849efdf15
commit 36e4df9d66
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java
View file

@ -867,14 +867,14 @@ public final class PKCS12KeyStore extends KeyStoreSpi {
{ {
SecretKey skey = null; SecretKey skey = null;
PBEKeySpec keySpec = new PBEKeySpec(password);
try { try {
PBEKeySpec keySpec = new PBEKeySpec(password);
SecretKeyFactory skFac = SecretKeyFactory.getInstance("PBE"); SecretKeyFactory skFac = SecretKeyFactory.getInstance("PBE");
skey = skFac.generateSecret(keySpec); skey = skFac.generateSecret(keySpec);
keySpec.clearPassword();
} catch (Exception e) { } catch (Exception e) {
throw new IOException("getSecretKey failed: " + throw new IOException("getSecretKey failed: " + e.getMessage(), e);
e.getMessage(), e); } finally {
keySpec.clearPassword();
} }
return skey; return skey;
} }