archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 14:54:52 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8314236: Overflow in Collections.rotate

Browse source 
Co-authored-by: Nikita Sakharin <17588081+nikita-sakharin@users.noreply.github.com>
Reviewed-by: shade, smarks
This commit is contained in:
Nikita Sakharin 2023-09-18 09:20:11 +00:00 • committed by Aleksey Shipilev
parent 1203e11a8d
commit 3828dc913a
2 changed files with 88 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/java.base/share/classes/java/util/Collections.java
View file

@ -816,15 +816,16 @@ public class Collections {
if (distance == 0)
return;
for (int cycleStart = 0, nMoved = 0; nMoved != size; cycleStart++) {
int bound = size - distance;
for (int cycleStart = 0, nMoved = 0; nMoved < size; cycleStart++) {
T displaced = list.get(cycleStart);
int i = cycleStart;
do {
i += distance;
if (i >= size)
if (i >= bound)
i -= size;
i += distance;
displaced = list.set(i, displaced);
nMoved ++;
nMoved++;
} while (i != cycleStart);
}
}