archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 15:24:43 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8236766: Remove un-used oops do and drain list in VM thread

Browse source 
Reviewed-by: dholmes, coleenp
This commit is contained in:
Robbin Ehn 2020-01-17 16:17:22 +01:00
parent a589a15e3f
commit 39992dea38
3 changed files with 0 additions and 79 deletions
Download patch file Download diff file Expand all files Collapse all files

63
src/hotspot/share/runtime/vmThread.cpp
View file

@ -62,7 +62,6 @@ VMOperationQueue::VMOperationQueue() {
_queue[i]->set_next(_queue[i]);
_queue[i]->set_prev(_queue[i]);
}
_drain_list = NULL;
}
@ -128,23 +127,6 @@ VM_Operation* VMOperationQueue::queue_drain(int prio) {
return r;
}
void VMOperationQueue::queue_oops_do(int queue, OopClosure* f) {
VM_Operation* cur = _queue[queue];
cur = cur->next();
while (cur != _queue[queue]) {
cur->oops_do(f);
cur = cur->next();
}
}
void VMOperationQueue::drain_list_oops_do(OopClosure* f) {
VM_Operation* cur = _drain_list;
while (cur != NULL) {
cur->oops_do(f);
cur = cur->next();
}
}
//-----------------------------------------------------------------
// High-level interface
void VMOperationQueue::add(VM_Operation *op) {
@ -179,13 +161,6 @@ VM_Operation* VMOperationQueue::remove_next() {
return queue_remove_front(queue_empty(high_prio) ? low_prio : high_prio);
}
void VMOperationQueue::oops_do(OopClosure* f) {
for(int i = 0; i < nof_priorities; i++) {
queue_oops_do(i, f);
}
drain_list_oops_do(f);
}
//------------------------------------------------------------------------------------------------------------------
// Timeout machinery
@ -534,8 +509,6 @@ void VMThread::loop() {
if (_cur_vm_operation->evaluate_at_safepoint()) {
log_debug(vmthread)("Evaluating safepoint VM operation: %s", _cur_vm_operation->name());
_vm_queue->set_drain_list(safepoint_ops); // ensure ops can be scanned
SafepointSynchronize::begin();
if (_timeout_task != NULL) {
@ -554,7 +527,6 @@ void VMThread::loop() {
// evaluate_operation deletes the op object so we have
// to grab the next op now
VM_Operation* next = _cur_vm_operation->next();
_vm_queue->set_drain_list(next);
evaluate_operation(_cur_vm_operation);
_cur_vm_operation = next;
_coalesced_count++;
@ -580,8 +552,6 @@ void VMThread::loop() {
}
} while(safepoint_ops != NULL);
_vm_queue->set_drain_list(NULL);
if (_timeout_task != NULL) {
_timeout_task->disarm();
}
@ -715,39 +685,6 @@ void VMThread::execute(VM_Operation* op) {
}
}
void VMThread::oops_do(OopClosure* f, CodeBlobClosure* cf) {
Thread::oops_do(f, cf);
_vm_queue->oops_do(f);
}
//------------------------------------------------------------------------------------------------------------------
#ifndef PRODUCT
void VMOperationQueue::verify_queue(int prio) {
// Check that list is correctly linked
int length = _queue_length[prio];
VM_Operation *cur = _queue[prio];
int i;
// Check forward links
for(i = 0; i < length; i++) {
cur = cur->next();
assert(cur != _queue[prio], "list to short (forward)");
}
assert(cur->next() == _queue[prio], "list to long (forward)");
// Check backwards links
cur = _queue[prio];
for(i = 0; i < length; i++) {
cur = cur->prev();
assert(cur != _queue[prio], "list to short (backwards)");
}
assert(cur->prev() == _queue[prio], "list to long (backwards)");
}
#endif
void VMThread::verify() {
oops_do(&VerifyOopClosure::verify_oop, NULL);
}