archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-26 22:34:27 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8198755: Reduce cost of InvokerBytecodeGenerator::isStaticallyInvocable/-Nameable

Browse source 
Reviewed-by: vlivanov, psandoz, jrose
This commit is contained in:
Claes Redestad 2018-02-27 21:05:07 +01:00
parent efeaca8cda
commit 3c9dfe26ed
1 changed files with 20 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java
View file

@ -928,6 +928,12 @@ class InvokerBytecodeGenerator {
if (member == null) return false;
if (member.isConstructor()) return false;
Class<?> cls = member.getDeclaringClass();
// Fast-path non-private members declared by MethodHandles, which is a common
// case
if (MethodHandle.class.isAssignableFrom(cls) && !member.isPrivate()) {
assert(isStaticallyInvocableType(member.getMethodOrFieldType()));
return true;
}
if (cls.isArray() || cls.isPrimitive())
return false; // FIXME
if (cls.isAnonymousClass() || cls.isLocalClass())
@ -936,12 +942,8 @@ class InvokerBytecodeGenerator {
return false; // not on BCP
if (ReflectUtil.isVMAnonymousClass(cls)) // FIXME: switch to supported API once it is added
return false;
MethodType mtype = member.getMethodOrFieldType();
if (!isStaticallyNameable(mtype.returnType()))
if (!isStaticallyInvocableType(member.getMethodOrFieldType()))
return false;
for (Class<?> ptype : mtype.parameterArray())
if (!isStaticallyNameable(ptype))
return false;
if (!member.isPrivate() && VerifyAccess.isSamePackage(MethodHandle.class, cls))
return true; // in java.lang.invoke package
if (member.isPublic() && isStaticallyNameable(cls))
@ -949,9 +951,22 @@ class InvokerBytecodeGenerator {
return false;
}
private static boolean isStaticallyInvocableType(MethodType mtype) {
if (!isStaticallyNameable(mtype.returnType()))
return false;
for (Class<?> ptype : mtype.parameterArray())
if (!isStaticallyNameable(ptype))
return false;
return true;
}
static boolean isStaticallyNameable(Class<?> cls) {
if (cls == Object.class)
return true;
if (MethodHandle.class.isAssignableFrom(cls)) {
assert(!ReflectUtil.isVMAnonymousClass(cls));
return true;
}
while (cls.isArray())
cls = cls.getComponentType();
if (cls.isPrimitive())