archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-19 10:34:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8242427: JVMTI frame pop operations should use Thread-Local Handshakes

Browse source 
Reviewed-by: dcubed, dholmes, pchilanomate, rehn, sspitsyn
This commit is contained in:
Yasumasa Suenaga 2020-09-05 12:42:05 +09:00
parent 5d2e79e2c3
commit 3e81b3ad48
11 changed files with 107 additions and 87 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/hotspot/share/prims/jvmtiEnvBase.cpp
View file

@ -1504,25 +1504,23 @@ JvmtiModuleClosure::get_all_modules(JvmtiEnv* env, jint* module_count_ptr, jobje
}
void
VM_UpdateForPopTopFrame::doit() {
UpdateForPopTopFrameClosure::do_thread(Thread *target) {
JavaThread* jt = _state->get_thread();
ThreadsListHandle tlh;
if (jt != NULL && tlh.includes(jt) && !jt->is_exiting() && jt->threadObj() != NULL) {
assert(jt == target, "just checking");
if (!jt->is_exiting() && jt->threadObj() != NULL) {
_state->update_for_pop_top_frame();
} else {
_result = JVMTI_ERROR_THREAD_NOT_ALIVE;
_result = JVMTI_ERROR_NONE;
}
}
void
VM_SetFramePop::doit() {
SetFramePopClosure::do_thread(Thread *target) {
JavaThread* jt = _state->get_thread();
ThreadsListHandle tlh;
if (jt != NULL && tlh.includes(jt) && !jt->is_exiting() && jt->threadObj() != NULL) {
assert(jt == target, "just checking");
if (!jt->is_exiting() && jt->threadObj() != NULL) {
int frame_number = _state->count_frames() - _depth;
_state->env_thread_state((JvmtiEnvBase*)_env)->set_frame_pop(frame_number);
} else {
_result = JVMTI_ERROR_THREAD_NOT_ALIVE;
_result = JVMTI_ERROR_NONE;
}
}