archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-18 10:04:42 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

6463710: ListSelectionModel.setSelectionMode() underspecified

Browse source 
Reviewed-by: serb, ssadetsky
This commit is contained in:
Pankaj Bansal 2017-10-25 16:34:11 +05:30 • committed by Ajit Ghaisas
parent 7ce7347fd2
commit 3ed8badb5a
2 changed files with 143 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/java.desktop/share/classes/javax/swing/DefaultListSelectionModel.java
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 1997, 2015, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1997, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -95,6 +95,7 @@ public class DefaultListSelectionModel implements ListSelectionModel, Cloneable,
* @throws IllegalArgumentException {@inheritDoc}
*/
public void setSelectionMode(int selectionMode) {
int oldMode = this.selectionMode;
switch (selectionMode) {
case SINGLE_SELECTION:
case SINGLE_INTERVAL_SELECTION:
@ -104,6 +105,24 @@ public class DefaultListSelectionModel implements ListSelectionModel, Cloneable,
default:
throw new IllegalArgumentException("invalid selectionMode");
}
/*
This code will only be executed when selection needs to be updated on
changing selection mode. It will happen only if selection mode is changed
from MULTIPLE_INTERVAL to SINGLE_INTERVAL or SINGLE or from
SINGLE_INTERVAL to SINGLE
*/
if (oldMode > this.selectionMode) {
if (this.selectionMode == SINGLE_SELECTION) {
setSelectionInterval(minIndex, minIndex);
} else if (this.selectionMode == SINGLE_INTERVAL_SELECTION) {
int selectionEndindex = minIndex;
while (value.get(selectionEndindex+1)) {
selectionEndindex++;
}
setSelectionInterval(minIndex, selectionEndindex);
}
}
}
/** {@inheritDoc} */