archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-20 11:04:34 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8043477: java/lang/ProcessBuilder/Basic.java failed with: java.lang.AssertionError: Some tests failed

Browse source 
Reviewed-by: martin
This commit is contained in:
Roger Riggs 2014-11-13 12:29:54 -05:00
parent ba945b418e
commit 4401923a82
1 changed files with 13 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

21
jdk/test/java/lang/ProcessBuilder/Basic.java
View file

@ -2269,9 +2269,10 @@ public class Basic {
fail("Test failed: Process exited prematurely"); fail("Test failed: Process exited prematurely");
} }
long end = System.nanoTime(); long end = System.nanoTime();
// give waitFor(timeout) a wide berth (200ms) // give waitFor(timeout) a wide berth (2s)
// Old AIX machines my need a little longer. System.out.printf(" waitFor process: delta: %d%n",(end - start) );
if ((end - start) > 200000000L * (AIX.is() ? 2 : 1))
if ((end - start) > TimeUnit.SECONDS.toNanos(2))
fail("Test failed: waitFor took too long (" + (end - start) + "ns)"); fail("Test failed: waitFor took too long (" + (end - start) + "ns)");
p.destroy(); p.destroy();
@ -2295,19 +2296,23 @@ public class Basic {
final Process p = new ProcessBuilder(childArgs).start(); final Process p = new ProcessBuilder(childArgs).start();
long start = System.nanoTime(); long start = System.nanoTime();
p.waitFor(1000, TimeUnit.MILLISECONDS); p.waitFor(10, TimeUnit.MILLISECONDS);
long end = System.nanoTime(); long end = System.nanoTime();
if ((end - start) < 500000000) if ((end - start) < TimeUnit.MILLISECONDS.toNanos(10))
fail("Test failed: waitFor didn't take long enough (" + (end - start) + "ns)"); fail("Test failed: waitFor didn't take long enough (" + (end - start) + "ns)");
p.destroy(); p.destroy();
start = System.nanoTime(); start = System.nanoTime();
p.waitFor(1000, TimeUnit.MILLISECONDS); p.waitFor(8, TimeUnit.SECONDS);
end = System.nanoTime(); end = System.nanoTime();
if ((end - start) > 900000000)
fail("Test failed: waitFor took too long on a dead process. (" + (end - start) + "ns)"); int exitValue = p.exitValue();
if ((end - start) > TimeUnit.SECONDS.toNanos(7))
fail("Test failed: waitFor took too long on a dead process. (" + (end - start) + "ns)"
+ ", exitValue: " + exitValue);
} catch (Throwable t) { unexpected(t); } } catch (Throwable t) { unexpected(t); }
//---------------------------------------------------------------- //----------------------------------------------------------------