archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-17 17:44:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8313678: SymbolTable can leak Symbols during cleanup

Browse source 
Reviewed-by: coleenp, dholmes, shade
This commit is contained in:
Oli Gillespie 2023-08-14 15:58:03 +00:00 • committed by Aleksey Shipilev
parent f41c267f85
commit 4b2703ad39
11 changed files with 68 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/hotspot/share/classfile/symbolTable.cpp
View file

@ -374,7 +374,11 @@ public:
uintx get_hash() const {
return _hash;
}
bool equals(Symbol* value, bool* is_dead) {
// Note: When equals() returns "true", the symbol's refcount is incremented. This is
// needed to ensure that the symbol is kept alive before equals() returns to the caller,
// so that another thread cannot clean the symbol up concurrently. The caller is
// responsible for decrementing the refcount, when the symbol is no longer needed.
bool equals(Symbol* value) {
assert(value != nullptr, "expected valid value");
Symbol *sym = value;
if (sym->equals(_str, _len)) {
@ -383,14 +387,15 @@ public:
return true;
} else {
assert(sym->refcount() == 0, "expected dead symbol");
*is_dead = true;
return false;
}
} else {
*is_dead = (sym->refcount() == 0);
return false;
}
}
bool is_dead(Symbol* value) {
return value->refcount() == 0;
}
};
class SymbolTableGet : public StackObj {