8209024: Use SuppressWarnings on serialVersionUID fields in interfaces

Reviewed-by: bpb, rriggs, mullan
2025-08-26 14:24:46 +02:00 · 2018-08-06 14:29:22 -07:00 · 2018-08-06 14:29:22 -07:00 · 4bac00436d
commit 4bac00436d
parent 080d3bb21a
20 changed files with 38 additions and 18 deletions
--- a/src/java.base/share/classes/java/security/Key.java
+++ b/src/java.base/share/classes/java/security/Key.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1996, 2017, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1996, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -109,6 +109,7 @@ public interface Key extends java.io.Serializable {
    * serialization compatibility with a previous
    * version of the class.
    */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = 6603384152749567654L;

    /**
--- a/src/java.base/share/classes/java/security/PrivateKey.java
+++ b/src/java.base/share/classes/java/security/PrivateKey.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1996, 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1996, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -64,5 +64,6 @@ public interface PrivateKey extends Key, javax.security.auth.Destroyable {
     * The class fingerprint that is set to indicate serialization
     * compatibility with a previous version of the class.
     */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = 6034044314589513430L;
 }
--- a/src/java.base/share/classes/java/security/PublicKey.java
+++ b/src/java.base/share/classes/java/security/PublicKey.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1996, 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1996, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -50,5 +50,6 @@ public interface PublicKey extends Key {
     * The class fingerprint that is set to indicate serialization
     * compatibility with a previous version of the class.
     */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = 7187392471159151072L;
 }
--- a/src/java.base/share/classes/java/security/interfaces/DSAPrivateKey.java
+++ b/src/java.base/share/classes/java/security/interfaces/DSAPrivateKey.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1997, 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -48,6 +48,7 @@ public interface DSAPrivateKey extends DSAKey, java.security.PrivateKey {
    * serialization compatibility with a previous
    * version of the class.
    */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = 7776497482533790279L;

    /**
--- a/src/java.base/share/classes/java/security/interfaces/DSAPublicKey.java
+++ b/src/java.base/share/classes/java/security/interfaces/DSAPublicKey.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1996, 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1996, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -48,6 +48,7 @@ public interface DSAPublicKey extends DSAKey, java.security.PublicKey {
    * serialization compatibility with a previous
    * version of the class.
    */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = 1234526332779022332L;

    /**
--- a/src/java.base/share/classes/java/security/interfaces/ECPrivateKey.java
+++ b/src/java.base/share/classes/java/security/interfaces/ECPrivateKey.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2003, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2003, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -43,6 +43,7 @@ public interface ECPrivateKey extends PrivateKey, ECKey {
    * The class fingerprint that is set to indicate
    * serialization compatibility.
    */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = -7896394956925609184L;

    /**
--- a/src/java.base/share/classes/java/security/interfaces/ECPublicKey.java
+++ b/src/java.base/share/classes/java/security/interfaces/ECPublicKey.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2003, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2003, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -45,6 +45,7 @@ public interface ECPublicKey extends PublicKey, ECKey {
    * The class fingerprint that is set to indicate
    * serialization compatibility.
    */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = -3314988629879632826L;

    /**
--- a/src/java.base/share/classes/java/security/interfaces/RSAMultiPrimePrivateCrtKey.java
+++ b/src/java.base/share/classes/java/security/interfaces/RSAMultiPrimePrivateCrtKey.java
@ -51,6 +51,7 @@ public interface RSAMultiPrimePrivateCrtKey extends RSAPrivateKey {
     * serialization compatibility with a previous
     * version of the type.
     */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = 618058533534628008L;

    /**
--- a/src/java.base/share/classes/java/security/interfaces/RSAPrivateCrtKey.java
+++ b/src/java.base/share/classes/java/security/interfaces/RSAPrivateCrtKey.java
@ -46,6 +46,7 @@ public interface RSAPrivateCrtKey extends RSAPrivateKey {
     * serialization compatibility with a previous
     * version of the type.
     */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = -5682214253527700368L;

    /**
--- a/src/java.base/share/classes/java/security/interfaces/RSAPrivateKey.java
+++ b/src/java.base/share/classes/java/security/interfaces/RSAPrivateKey.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1998, 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -45,6 +45,7 @@ public interface RSAPrivateKey extends java.security.PrivateKey, RSAKey
     * serialization compatibility with a previous
     * version of the type.
     */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = 5187144804936595022L;

    /**
--- a/src/java.base/share/classes/java/security/interfaces/RSAPublicKey.java
+++ b/src/java.base/share/classes/java/security/interfaces/RSAPublicKey.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1998, 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -42,6 +42,7 @@ public interface RSAPublicKey extends java.security.PublicKey, RSAKey
     * serialization compatibility with a previous
     * version of the type.
     */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = -8727434096241101194L;

    /**
--- a/src/java.base/share/classes/javax/crypto/SecretKey.java
+++ b/src/java.base/share/classes/javax/crypto/SecretKey.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1997, 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -64,5 +64,6 @@ public interface SecretKey extends
     * The class fingerprint that is set to indicate serialization
     * compatibility since J2SE 1.4.
     */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = -4795878709595146952L;
 }
--- a/src/java.base/share/classes/javax/crypto/interfaces/DHPrivateKey.java
+++ b/src/java.base/share/classes/javax/crypto/interfaces/DHPrivateKey.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1997, 2007, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -42,6 +42,7 @@ public interface DHPrivateKey extends DHKey, java.security.PrivateKey {
     * The class fingerprint that is set to indicate serialization
     * compatibility since J2SE 1.4.
     */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = 2211791113380396553L;

    /**
--- a/src/java.base/share/classes/javax/crypto/interfaces/DHPublicKey.java
+++ b/src/java.base/share/classes/javax/crypto/interfaces/DHPublicKey.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1997, 2007, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -42,6 +42,7 @@ public interface DHPublicKey extends DHKey, java.security.PublicKey {
     * The class fingerprint that is set to indicate serialization
     * compatibility since J2SE 1.4.
     */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = -6628103563352519193L;

    /**
--- a/src/java.base/share/classes/javax/crypto/interfaces/PBEKey.java
+++ b/src/java.base/share/classes/javax/crypto/interfaces/PBEKey.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2001, 2007, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2001, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -42,6 +42,7 @@ public interface PBEKey extends javax.crypto.SecretKey {
     * The class fingerprint that is set to indicate serialization
     * compatibility since J2SE 1.4.
     */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = -1430015993304333921L;

    /**
--- a/src/java.base/share/classes/sun/security/internal/interfaces/TlsMasterSecret.java
+++ b/src/java.base/share/classes/sun/security/internal/interfaces/TlsMasterSecret.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2005, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -44,6 +44,7 @@ import javax.crypto.SecretKey;
@Deprecated
 public interface TlsMasterSecret extends SecretKey {

+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    public static final long serialVersionUID = -461748105810469773L;

    /**
--- a/src/java.naming/share/classes/javax/naming/Name.java
+++ b/src/java.naming/share/classes/javax/naming/Name.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1999, 2004, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1999, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -64,6 +64,7 @@ public interface Name
    * serialization compatibility with a previous
    * version of the class.
    */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = -3617482732056931635L;

    /**
--- a/src/java.naming/share/classes/javax/naming/directory/Attribute.java
+++ b/src/java.naming/share/classes/javax/naming/directory/Attribute.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1999, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -336,5 +336,6 @@ public interface Attribute extends Cloneable, java.io.Serializable {
    /**
     * Use serialVersionUID from JNDI 1.1.1 for interoperability.
     */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = 8707690322213556804L;
 }
--- a/src/java.rmi/share/classes/java/rmi/server/RemoteRef.java
+++ b/src/java.rmi/share/classes/java/rmi/server/RemoteRef.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1996, 2004, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1996, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -39,6 +39,7 @@ import java.rmi.*;
 public interface RemoteRef extends java.io.Externalizable {

    /** indicate compatibility with JDK 1.1.x version of class. */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = 3632638527362204081L;

    /**
--- a/src/java.rmi/share/classes/java/rmi/server/ServerRef.java
+++ b/src/java.rmi/share/classes/java/rmi/server/ServerRef.java
@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1996, 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1996, 2018, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
@ -39,6 +39,7 @@ import java.rmi.*;
 public interface ServerRef extends RemoteRef {

    /** indicate compatibility with JDK 1.1.x version of class. */
+    @SuppressWarnings("serial") // serialVersionUID in an interface is ineffectual
    static final long serialVersionUID = -4557750989390278438L;

    /**