archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 06:45:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8294717: (bf) DirectByteBuffer constructor will leak if allocating Deallocator or Cleaner fails with OOME

Browse source 
Reviewed-by: alanb
This commit is contained in:
Brian Burkhalter 2022-10-07 17:43:00 +00:00
parent c1166a304d
commit 4cbac40de9
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template
View file

@ -141,7 +141,14 @@ class Direct$Type$Buffer$RW$$BO$
} else { } else {
address = base; address = base;
} }
try {
cleaner = Cleaner.create(this, new Deallocator(base, size, cap)); cleaner = Cleaner.create(this, new Deallocator(base, size, cap));
} catch (Throwable t) {
// Prevent leak if the Deallocator or Cleaner fail for any reason
UNSAFE.freeMemory(base);
Bits.unreserveMemory(size, cap);
throw t;
}
att = null; att = null;
#else[rw] #else[rw]
super(cap); super(cap);