archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-19 02:24:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8261730: C2 compilation fails with assert(store->find_edge(load) != -1) failed: missing precedence edge

Browse source 
Relax assertion in PhaseCFG::verify() to accept the case where a store is used
to implement an implicit null check and a load is placed in the null block.

Reviewed-by: thartmann, kvn
This commit is contained in:
Roberto Castañeda Lozano 2021-03-04 07:48:51 +00:00
parent 7915a1fc4c
commit 4cfecceb04
4 changed files with 82 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

61
test/hotspot/jtreg/compiler/uncommontrap/TestNullCheckAntiDependence.java Normal file
View file

@ -0,0 +1,61 @@
/*
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
package compiler.uncommontrap;
/**
* @test
* @bug 8261730
* @summary Test that no anti-dependence violation is reported between a store
* used as an implicit null check and a load placed in the null block.
* @run main/othervm -XX:-BackgroundCompilation
* compiler.uncommontrap.TestNullCheckAntiDependence
*/
public class TestNullCheckAntiDependence {
private static class MyInteger {
int val;
}
private static MyInteger foo = new MyInteger();
private static MyInteger bar = new MyInteger();
static void setFooToZero() {
for (int i = 0; i < 1; i++) {
// This load is placed in the null block.
foo.val = -bar.val;
for (int k = 0; k < 10; k++) {
// This store is hoisted and used as an implicit null check.
foo.val = 0;
}
}
}
public static void main(String[] args) {
for (int i = 0; i < 10_000; i++) {
setFooToZero();
}
}
}