archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 06:45:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8333396: Use StringBuilder internally for java.text.Format.* formatting

Browse source 
Reviewed-by: naoto, liach, jlu
This commit is contained in:
lingjun.cg 2024-07-22 02:01:08 +00:00
parent fd741a88e8
commit 4da9915875
16 changed files with 764 additions and 73 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/java.base/share/classes/java/text/MessageFormat.java
View file

@ -1027,12 +1027,13 @@ public class MessageFormat extends Format {
public final StringBuffer format(Object[] arguments, StringBuffer result,
FieldPosition pos)
{
return subformat(arguments, result, pos, null);
return subformat(arguments, StringBufFactory.of(result), pos, null).asStringBuffer();
}
/**
* Creates a MessageFormat with the given pattern and uses it
* to format the given arguments. This is equivalent to
* to format the given arguments.
* This method returns a string that would be equal to the string returned by
* <blockquote>
* <code>(new {@link #MessageFormat(String) MessageFormat}(pattern)).{@link #format(java.lang.Object[], java.lang.StringBuffer, java.text.FieldPosition) format}(arguments, new StringBuffer(), null).toString()</code>
* </blockquote>
@ -1076,6 +1077,12 @@ public class MessageFormat extends Format {
public final StringBuffer format(Object arguments, StringBuffer result,
FieldPosition pos)
{
return subformat((Object[]) arguments, StringBufFactory.of(result), pos, null).asStringBuffer();
}
@Override
final StringBuf format(Object arguments, StringBuf result,
FieldPosition pos) {
return subformat((Object[]) arguments, result, pos, null);
}
@ -1116,7 +1123,7 @@ public class MessageFormat extends Format {
*/
public AttributedCharacterIterator formatToCharacterIterator(Object arguments) {
Objects.requireNonNull(arguments, "arguments must not be null");
StringBuffer result = new StringBuffer();
StringBuf result = StringBufFactory.of();
ArrayList<AttributedCharacterIterator> iterators = new ArrayList<>();
subformat((Object[]) arguments, result, null, iterators);
@ -1472,7 +1479,7 @@ public class MessageFormat extends Format {
* {@code arguments} array is not of the type
* expected by the format element(s) that use it.
*/
private StringBuffer subformat(Object[] arguments, StringBuffer result,
private StringBuf subformat(Object[] arguments, StringBuf result,
FieldPosition fp, List<AttributedCharacterIterator> characterIterators) {
// note: this implementation assumes a fast substring & index.
// if this is not true, would be better to append chars one by one.
@ -1582,9 +1589,9 @@ public class MessageFormat extends Format {
/**
* Convenience method to append all the characters in
* {@code iterator} to the StringBuffer {@code result}.
* {@code iterator} to the StringBuf {@code result}.
*/
private void append(StringBuffer result, CharacterIterator iterator) {
private void append(StringBuf result, CharacterIterator iterator) {
if (iterator.first() != CharacterIterator.DONE) {
char aChar;