archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 07:14:30 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8276798: HttpURLConnection sends invalid HTTP request

Browse source 
Reviewed-by: dfuchs, michaelm
This commit is contained in:
Jaikiran Pai 2022-06-22 14:45:52 +00:00
parent 270cf67e5f
commit 50c37f53f2
1 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java
View file

@ -626,10 +626,13 @@ public class HttpURLConnection extends java.net.HttpURLConnection {
* to last and last, respectively, in the case of a POST * to last and last, respectively, in the case of a POST
* request. * request.
*/ */
if (!failedOnce) { final String requestLine = method + " " + getRequestURI()+ " " + httpVersion;
final int requestLineIndex = requests.getKey(requestLine);
if (requestLineIndex != 0) {
// we expect the request line to be at index 0. we set it here
// if we don't find the request line at that index.
checkURLFile(); checkURLFile();
requests.prepend(method + " " + getRequestURI()+" " + requests.prepend(requestLine, null);
httpVersion, null);
} }
if (!getUseCaches()) { if (!getUseCaches()) {
requests.setIfNotSet ("Cache-Control", "no-cache"); requests.setIfNotSet ("Cache-Control", "no-cache");
@ -656,8 +659,7 @@ public class HttpURLConnection extends java.net.HttpURLConnection {
* or if keep alive is disabled via a system property * or if keep alive is disabled via a system property
*/ */
// Try keep-alive only on first attempt if (http.getHttpKeepAliveSet()) {
if (!failedOnce && http.getHttpKeepAliveSet()) {
if (http.usingProxy && tunnelState() != TunnelState.TUNNELING) { if (http.usingProxy && tunnelState() != TunnelState.TUNNELING) {
requests.setIfNotSet("Proxy-Connection", "keep-alive"); requests.setIfNotSet("Proxy-Connection", "keep-alive");
} else { } else {