archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-17 17:44:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8214059: Undefined behaviour in ADLC

Browse source 
Reviewed-by: shade, kbarrett
This commit is contained in:
Simon Tooke 2018-11-26 09:36:30 +01:00 • committed by Severin Gehwolf
parent 40d4ff864c
commit 5d725a98c8
3 changed files with 25 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/hotspot/share/adlc/formssel.cpp
View file

@ -919,7 +919,8 @@ void InstructForm::build_components() {
const char *name;
const char *kill_name = NULL;
for (_parameters.reset(); (name = _parameters.iter()) != NULL;) {
OperandForm *opForm = (OperandForm*)_localNames[name];
OpClassForm *opForm = _localNames[name]->is_opclass();
assert(opForm != NULL, "sanity");
Effect* e = NULL;
{
@ -936,7 +937,8 @@ void InstructForm::build_components() {
// complex so simply enforce the restriction during parse.
if (kill_name != NULL &&
e->isa(Component::TEMP) && !e->isa(Component::DEF)) {
OperandForm* kill = (OperandForm*)_localNames[kill_name];
OpClassForm* kill = _localNames[kill_name]->is_opclass();
assert(kill != NULL, "sanity");
globalAD->syntax_err(_linenum, "%s: %s %s must be at the end of the argument list\n",
_ident, kill->_ident, kill_name);
} else if (e->isa(Component::KILL) && !e->isa(Component::USE)) {
@ -2350,7 +2352,8 @@ void OperandForm::build_components() {
// Add parameters that "do not appear in match rule".
const char *name;
for (_parameters.reset(); (name = _parameters.iter()) != NULL;) {
OperandForm *opForm = (OperandForm*)_localNames[name];
OpClassForm *opForm = _localNames[name]->is_opclass();
assert(opForm != NULL, "sanity");
if ( _components.operand_position(name) == -1 ) {
_components.insert(name, opForm->_ident, Component::INVALID, false);