archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-20 11:04:34 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8166538: Improve error reporting for compiling against unexported package

Browse source 
When a type cannot be found, look into other modules, search for possible viable types, and report them conveniently to the user.

Reviewed-by: mcimadamore, jjg
This commit is contained in:
Jan Lahoda 2016-11-02 16:48:57 +01:00
parent 0032be0658
commit 5daafbe43b
71 changed files with 1926 additions and 114 deletions
Download patch file Download diff file Expand all files Collapse all files

14
langtools/test/tools/javac/modules/RequiresPublicTest.java
View file

@ -85,7 +85,7 @@ public class RequiresPublicTest extends ModuleTestBase {
.writeAll()
.getOutput(Task.OutputKind.DIRECT);
if (!log.contains("Test.java:1:27: compiler.err.doesnt.exist: com.sun.source.tree"))
if (!log.contains("Test.java:1:22: compiler.err.package.not.visible: com.sun.source.tree, (compiler.misc.not.def.access.does.not.read: m, com.sun.source.tree, jdk.compiler)"))
throw new Exception("expected output not found");
}
@ -121,15 +121,9 @@ public class RequiresPublicTest extends ModuleTestBase {
.getOutput(Task.OutputKind.DIRECT);
String[] expect = {
"C1.java:5:10: compiler.err.not.def.access.package.cant.access: p5.C5, p5",
"C1.java:5:24: compiler.err.not.def.access.package.cant.access: p6.C6, p6",
"C1.java:5:38: compiler.err.not.def.access.package.cant.access: p7.C7, p7",
"C1.java:8:1: compiler.err.cant.resolve.location: kindname.class, C5, , , "
+ "(compiler.misc.location: kindname.class, p1.C1, null)",
"C1.java:8:8: compiler.err.cant.resolve.location: kindname.class, C6, , , "
+ "(compiler.misc.location: kindname.class, p1.C1, null)",
"C1.java:8:15: compiler.err.cant.resolve.location: kindname.class, C7, , , "
+ "(compiler.misc.location: kindname.class, p1.C1, null)"
"C1.java:5:8: compiler.err.package.not.visible: p5, (compiler.misc.not.def.access.does.not.read: m1, p5, m5)",
"C1.java:5:22: compiler.err.package.not.visible: p6, (compiler.misc.not.def.access.does.not.read: m1, p6, m6)",
"C1.java:5:36: compiler.err.package.not.visible: p7, (compiler.misc.not.def.access.does.not.read: m1, p7, m7)"
};
for (String e: expect) {