archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-15 16:44:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8302870: More information needed from failures in vmTestbase ThreadUtils.waitThreadState

Browse source 
Reviewed-by: dholmes, sspitsyn
This commit is contained in:
Kevin Walls 2023-02-22 09:29:57 +00:00
parent 7f35389533
commit 5e1d1b7940
1 changed files with 28 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

33
test/hotspot/jtreg/vmTestbase/nsk/monitoring/share/thread/ThreadUtils.java
View file

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2007, 2018, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2007, 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
@ -25,6 +25,8 @@ package nsk.monitoring.share.thread;
import nsk.share.log.Log; import nsk.share.log.Log;
import nsk.share.TestFailure; import nsk.share.TestFailure;
import java.io.PrintStream;
import java.lang.management.LockInfo; import java.lang.management.LockInfo;
import java.lang.management.MonitorInfo; import java.lang.management.MonitorInfo;
import java.lang.management.ThreadInfo; import java.lang.management.ThreadInfo;
@ -203,6 +205,14 @@ public final class ThreadUtils {
} }
public static void printStackTrace(PrintStream out, Thread t) {
StackTraceElement[] stacktrace = t.getStackTrace();
for (int i = 0; i < stacktrace.length; i++) {
StackTraceElement ste = stacktrace[i];
out.println(INDENT + "at " + ste.toString());
}
}
/** /**
* Dump information about threads. * Dump information about threads.
* *
@ -218,20 +228,33 @@ public final class ThreadUtils {
} }
} }
// Most uses of waitThreadState usually succeed without retries.
// These values should avoid spurious failures.
public final static int waitThreadStateRetries = 10; public final static int waitThreadStateRetries = 10;
public final static long waitThreadStateSleepTime = 100; public final static long waitThreadStateSleepTime = 1000;
public static void waitThreadState(Thread thread, Thread.State state) { public static void waitThreadState(Thread thread, Thread.State state) {
int retries = 0; int retries = 0;
long ctime = System.currentTimeMillis(); long startTime = System.currentTimeMillis();
long elapsedTime = 0;
while (thread.getState() != state) { while (thread.getState() != state) {
if (retries++ > waitThreadStateRetries) if (retries++ > waitThreadStateRetries) {
throw new TestFailure("Thread " + thread + " with current state " + thread.getState() + " did not reach state " + state + " with number of retries: " + retries + ", time: " + (System.currentTimeMillis() - ctime)); // Failed to see desired state, give info to help diagnose the isuse.
// Show the thread, and fail with Exception showing retries and time taken.
elapsedTime = System.currentTimeMillis() - startTime;
System.err.println("waitThreadState: problem thread: " + thread);
printStackTrace(System.err, thread);
throw new TestFailure("Thread " + thread + " with current state " + thread.getState() + " did not reach state "
+ state + " with number of retries: " + retries + ", time: " + elapsedTime);
}
try { try {
Thread.sleep(waitThreadStateSleepTime); Thread.sleep(waitThreadStateSleepTime);
} catch (InterruptedException e) { } catch (InterruptedException e) {
} }
} }
// Show retries and time, so we know what "normal" looks like:
elapsedTime = System.currentTimeMillis() - startTime;
System.out.println("waitThreadState: OK. retries: " + retries + " time: " + elapsedTime);
} }
/** /**