archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-20 02:54:35 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8023679: Improve error message for '_' used as a lambda parameter name

Browse source 
Reviewed-by: jjg, dlsmith
This commit is contained in:
Vicente Romero 2013-10-02 17:04:51 +01:00
parent d9502c856a
commit 696179bbda
3 changed files with 33 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
langtools/src/share/classes/com/sun/tools/javac/parser/JavacParser.java
View file

@ -3002,8 +3002,9 @@ public class JavacParser implements Parser {
int pos = token.pos; int pos = token.pos;
Name name; Name name;
if (lambdaParameter && token.kind == UNDERSCORE) { if (lambdaParameter && token.kind == UNDERSCORE) {
syntaxError(pos, "expected", IDENTIFIER); log.error(pos, "underscore.as.identifier.in.lambda");
name = token.name(); name = token.name();
nextToken();
} else { } else {
if (allowThisIdent) { if (allowThisIdent) {
JCExpression pn = qualident(false); JCExpression pn = qualident(false);

4
langtools/src/share/classes/com/sun/tools/javac/resources/compiler.properties
View file

@ -2224,6 +2224,10 @@ compiler.warn.underscore.as.identifier=\
''_'' used as an identifier\n\ ''_'' used as an identifier\n\
(use of ''_'' as an identifier might not be supported in releases after Java SE 8) (use of ''_'' as an identifier might not be supported in releases after Java SE 8)
compiler.err.underscore.as.identifier.in.lambda=\
''_'' used as an identifier\n\
(use of ''_'' as an identifier is forbidden for lambda parameters)
compiler.err.enum.as.identifier=\ compiler.err.enum.as.identifier=\
as of release 5, ''enum'' is a keyword, and may not be used as an identifier\n\ as of release 5, ''enum'' is a keyword, and may not be used as an identifier\n\
(use -source 1.4 or lower to use ''enum'' as an identifier) (use -source 1.4 or lower to use ''enum'' as an identifier)

27
langtools/test/tools/javac/diags/examples/UnderscoreInLambdaExpression.java Normal file
View file

@ -0,0 +1,27 @@
/*
* Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
// key: compiler.err.underscore.as.identifier.in.lambda
public class UnderscoreInLambdaExpression {
java.util.function.Function<String,String> f = _ -> "x";
}