archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-18 01:54:47 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8203680: os::stat() on Posix platform does not need to copy input path

Browse source 
Reviewed-by: hseigel, dholmes
This commit is contained in:
Thomas Stuefe 2018-06-19 09:34:41 +02:00
parent 79fea6b201
commit 6f462fbc70
9 changed files with 10 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/hotspot/os/aix/os_aix.cpp
View file

@ -3737,16 +3737,6 @@ bool os::message_box(const char* title, const char* message) {
return buf[0] == 'y' || buf[0] == 'Y';
}
int os::stat(const char *path, struct stat *sbuf) {
char pathbuf[MAX_PATH];
if (strlen(path) > MAX_PATH - 1) {
errno = ENAMETOOLONG;
return -1;
}
os::native_path(strcpy(pathbuf, path));
return ::stat(pathbuf, sbuf);
}
// Is a (classpath) directory empty?
bool os::dir_is_empty(const char* path) {
DIR *dir = NULL;

4
src/hotspot/os/aix/os_aix.inline.hpp
View file

@ -93,10 +93,6 @@ inline int os::fsync(int fd) {
return ::fsync(fd);
}
inline char* os::native_path(char *path) {
return path;
}
inline int os::ftruncate(int fd, jlong length) {
return ::ftruncate64(fd, length);
}

10
src/hotspot/os/bsd/os_bsd.cpp
View file

@ -3489,16 +3489,6 @@ bool os::message_box(const char* title, const char* message) {
return buf[0] == 'y' || buf[0] == 'Y';
}
int os::stat(const char *path, struct stat *sbuf) {
char pathbuf[MAX_PATH];
if (strlen(path) > MAX_PATH - 1) {
errno = ENAMETOOLONG;
return -1;
}
os::native_path(strcpy(pathbuf, path));
return ::stat(pathbuf, sbuf);
}
static inline struct timespec get_mtime(const char* filename) {
struct stat st;
int ret = os::stat(filename, &st);

4
src/hotspot/os/bsd/os_bsd.inline.hpp
View file

@ -96,10 +96,6 @@ inline int os::fsync(int fd) {
return ::fsync(fd);
}
inline char* os::native_path(char *path) {
return path;
}
inline int os::ftruncate(int fd, jlong length) {
return ::ftruncate(fd, length);
}

10
src/hotspot/os/linux/os_linux.cpp
View file

@ -5378,16 +5378,6 @@ bool os::message_box(const char* title, const char* message) {
return buf[0] == 'y' || buf[0] == 'Y';
}
int os::stat(const char *path, struct stat *sbuf) {
char pathbuf[MAX_PATH];
if (strlen(path) > MAX_PATH - 1) {
errno = ENAMETOOLONG;
return -1;
}
os::native_path(strcpy(pathbuf, path));
return ::stat(pathbuf, sbuf);
}
// Is a (classpath) directory empty?
bool os::dir_is_empty(const char* path) {
DIR *dir = NULL;

4
src/hotspot/os/linux/os_linux.inline.hpp
View file

@ -88,10 +88,6 @@ inline int os::fsync(int fd) {
return ::fsync(fd);
}
inline char* os::native_path(char *path) {
return path;
}
inline int os::ftruncate(int fd, jlong length) {
return ::ftruncate64(fd, length);
}

7
src/hotspot/os/posix/os_posix.cpp
View file

@ -1334,6 +1334,13 @@ char* os::Posix::realpath(const char* filename, char* outbuf, size_t outbuflen)
}
int os::stat(const char *path, struct stat *sbuf) {
return ::stat(path, sbuf);
}
char * os::native_path(char *path) {
return path;
}
// Check minimum allowable stack sizes for thread creation and to initialize
// the java system classes, including StackOverflowError - depends on page

14
src/hotspot/os/solaris/os_solaris.cpp
View file

@ -1667,16 +1667,6 @@ void* os::get_default_process_handle() {
return (void*)::dlopen(NULL, RTLD_LAZY);
}
int os::stat(const char *path, struct stat *sbuf) {
char pathbuf[MAX_PATH];
if (strlen(path) > MAX_PATH - 1) {
errno = ENAMETOOLONG;
return -1;
}
os::native_path(strcpy(pathbuf, path));
return ::stat(pathbuf, sbuf);
}
static inline time_t get_mtime(const char* filename) {
struct stat st;
int ret = os::stat(filename, &st);
@ -4474,10 +4464,6 @@ jlong os::lseek(int fd, jlong offset, int whence) {
return (jlong) ::lseek64(fd, offset, whence);
}
char * os::native_path(char *path) {
return path;
}
int os::ftruncate(int fd, jlong length) {
return ::ftruncate64(fd, length);
}

3
src/hotspot/share/runtime/os.hpp
View file

@ -558,6 +558,9 @@ class os: AllStatic {
static FILE* fopen(const char* path, const char* mode);
static int close(int fd);
static jlong lseek(int fd, jlong offset, int whence);
// This function, on Windows, canonicalizes a given path (see os_windows.cpp for details).
// On Posix, this function is a noop: it does not change anything and just returns
// the input pointer.
static char* native_path(char *path);
static int ftruncate(int fd, jlong length);
static int fsync(int fd);