archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-18 10:04:42 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8284944: assert(cnt++ < 40) failed: infinite cycle in loop optimization

Browse source 
Reviewed-by: kvn, chagedorn
This commit is contained in:
Tobias Holenstein 2022-05-25 13:48:19 +00:00 • committed by Christian Hagedorn
parent e534c133af
commit 796494d0fe
2 changed files with 125 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/hotspot/share/opto/compile.cpp
View file

@ -2059,10 +2059,8 @@ void Compile::process_late_inline_calls_no_inline(PhaseIterGVN& igvn) {
bool Compile::optimize_loops(PhaseIterGVN& igvn, LoopOptsMode mode) { bool Compile::optimize_loops(PhaseIterGVN& igvn, LoopOptsMode mode) {
if (_loop_opts_cnt > 0) { if (_loop_opts_cnt > 0) {
debug_only( int cnt = 0; );
while (major_progress() && (_loop_opts_cnt > 0)) { while (major_progress() && (_loop_opts_cnt > 0)) {
TracePhase tp("idealLoop", &timers[_t_idealLoop]); TracePhase tp("idealLoop", &timers[_t_idealLoop]);
assert( cnt++ < 40, "infinite cycle in loop optimization" );
PhaseIdealLoop::optimize(igvn, mode); PhaseIdealLoop::optimize(igvn, mode);
_loop_opts_cnt--; _loop_opts_cnt--;
if (failing()) return false; if (failing()) return false;

125
test/hotspot/jtreg/compiler/loopopts/TestMaxLoopOptsCountReached.java Normal file
View file

@ -0,0 +1,125 @@
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* @test
* @bug 8284944
* @requires vm.compiler2.enabled
* @summary triggers the loop optimization phase `LoopOptsCount` many times
* @run main/othervm -Xcomp -XX:-PartialPeelLoop -XX:CompileCommand=compileonly,TestMaxLoopOptsCountReached::test TestMaxLoopOptsCountReached
*/
import java.lang.System.Logger.Level;
public class TestMaxLoopOptsCountReached {
static Long a = Long.valueOf(42);
class A {
static String e(long f, boolean b, String g, Level h, String s,
Object... i) {
return "message" + s + new String() + g;
}
}
public static void main(String[] args) {
test(null, "", null, null);
test(null, "", null, null);
}
static void test(Integer o, String g, String name, Object obj) {
for (Level q : Level.values())
for (Level r : Level.values())
A.e(a.longValue(), q != Level.OFF, g, null, null);
for (Level q : Level.values())
for (Level r : Level.values())
A.e(a.longValue(), q != Level.OFF, g, null, null);
for (Level q : Level.values()) {
for (Level r : Level.values()) {
String msg = q + "message";
String val =
(q != Level.OFF || name != msg)
? A.e(a.longValue(), q != Level.OFF, g, null, null, "foo")
: null;
}
for (Level r : Level.values()) {
String msg = q + "message";
String val =
(q != Level.OFF || name != msg)
? A.e(a.longValue(), q != Level.OFF, g, null, null, "foo")
: null;
}
}
for (Level q : Level.values()) {
for (Level r : Level.values()) {
String msg = q + "message";
String val =
(q != Level.OFF || name != msg)
? A.e(a.longValue(), q != Level.OFF, g, null, null, "foo")
: null;
}
for (Level r : Level.values()) {
String msg = q + "message";
String val =
(q != Level.OFF || name != msg)
? A.e(a.longValue(), q != Level.OFF, g, null, null, "foo")
: null;
}
}
for (Level q : Level.values()) {
for (Level r : Level.values()) {
String msg = q + "message";
String val =
(q != Level.OFF || name != msg)
? A.e(a.longValue(), q != Level.OFF, g, null, null, "foo")
: null;
}
for (Level r : Level.values())
;
}
for (Level q : Level.values()) {
for (Level r : Level.values())
;
for (Level r : Level.values())
;
}
for (Level q : Level.values()) {
for (Level r : Level.values()) {
String msg = q + "message";
String val =
(q != Level.OFF || name != msg)
? A.e(a.longValue(), q != Level.OFF, g, null, null, "foo")
: null;
}
for (Level r : Level.values())
;
}
for (Level q : Level.values()) {
for (Level r : Level.values())
;
for (Level r : Level.values())
;
}
}
}