archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-16 09:04:41 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

7195622: CheckUnhandledOops has limited usefulness now

Browse source 
Enable CHECK_UNHANDLED_OOPS in fastdebug builds across all supported platforms.

Reviewed-by: coleenp, hseigel, dholmes, stefank, twisti, ihse, rdurbin
This commit is contained in:
Lois Foltan 2013-09-26 10:25:02 -04:00 • committed by Harold Seigel
parent 18550f7774
commit 7bf953d005
62 changed files with 208 additions and 173 deletions
Download patch file Download diff file Expand all files Collapse all files

10
hotspot/src/share/vm/utilities/taskqueue.hpp
View file

@ -322,11 +322,11 @@ public:
// Attempts to claim a task from the "local" end of the queue (the most
// recently pushed). If successful, returns true and sets t to the task;
// otherwise, returns false (the queue is empty).
inline bool pop_local(E& t);
inline bool pop_local(volatile E& t);
// Like pop_local(), but uses the "global" end of the queue (the least
// recently pushed).
bool pop_global(E& t);
bool pop_global(volatile E& t);
// Delete any resource associated with the queue.
~GenericTaskQueue();
@ -424,7 +424,7 @@ bool GenericTaskQueue<E, F, N>::pop_local_slow(uint localBot, Age oldAge) {
}
template<class E, MEMFLAGS F, unsigned int N>
bool GenericTaskQueue<E, F, N>::pop_global(E& t) {
bool GenericTaskQueue<E, F, N>::pop_global(volatile E& t) {
Age oldAge = _age.get();
// Architectures with weak memory model require a barrier here
// to guarantee that bottom is not older than age,
@ -701,7 +701,7 @@ GenericTaskQueue<E, F, N>::push(E t) {
}
template<class E, MEMFLAGS F, unsigned int N> inline bool
GenericTaskQueue<E, F, N>::pop_local(E& t) {
GenericTaskQueue<E, F, N>::pop_local(volatile E& t) {
uint localBot = _bottom;
// This value cannot be N-1. That can only occur as a result of
// the assignment to bottom in this method. If it does, this method
@ -799,7 +799,7 @@ public:
}
volatile ObjArrayTask&
operator =(const volatile ObjArrayTask& t) volatile {
_obj = t._obj;
(void)const_cast<oop&>(_obj = t._obj);
_index = t._index;
return *this;
}