archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 06:45:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8305343: BigDecimal.fractionOnly() erroneously returns true for large scale value

Browse source 
Reviewed-by: darcy
This commit is contained in:
Raffaello Giulietti 2023-04-04 18:09:04 +00:00
parent dd59471798
commit 7c650489d2
2 changed files with 36 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/java.base/share/classes/java/math/BigDecimal.java
View file

@ -3596,7 +3596,7 @@ public class BigDecimal extends Number implements Comparable<BigDecimal> {
*/
private boolean fractionOnly() {
assert this.signum() != 0;
return (this.precision() - this.scale) <= 0;
return this.precision() <= this.scale;
}
/**
@ -3624,8 +3624,15 @@ public class BigDecimal extends Number implements Comparable<BigDecimal> {
if (fractionOnly())
throw new ArithmeticException("Rounding necessary");
// If more than 19 digits in integer part it cannot possibly fit
if ((precision() - scale) > 19) // [OK for negative scale too]
/*
* If more than 19 digits in integer part it cannot possibly fit.
* Ensure that arithmetic does not overflow, so instead of
* precision() - scale > 19
* prefer
* precision() - 19 > scale
* since precision() > 0, so the lhs cannot overflow.
*/
if (precision() - 19 > scale) // [OK for negative scale too]
throw new java.lang.ArithmeticException("Overflow");
// round to an integer, with Exception if decimal part non-0