archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-17 09:34:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8256814: WeakProcessorPhases may be redundant

Browse source 
Remove WeakProcessorPhase, adding scoped enum categories to OopStorageSet.

Reviewed-by: stefank, tschatzl, rkennke
This commit is contained in:
Kim Barrett 2021-01-22 13:12:39 +00:00
parent bfac3fb595
commit 7ed8ba1ca0
23 changed files with 348 additions and 415 deletions
Download patch file Download diff file Expand all files Collapse all files

106
src/hotspot/share/gc/shared/weakProcessorPhaseTimes.hpp
View file

@ -1,106 +0,0 @@
/*
* Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*
*/
#ifndef SHARE_GC_SHARED_WEAKPROCESSORPHASETIMES_HPP
#define SHARE_GC_SHARED_WEAKPROCESSORPHASETIMES_HPP
#include "gc/shared/weakProcessorPhase.hpp"
#include "memory/allocation.hpp"
#include "utilities/globalDefinitions.hpp"
#include "utilities/ticks.hpp"
template<typename T> class WorkerDataArray;
class WeakProcessorPhaseTimes {
enum {
DeadItems,
TotalItems
};
uint _max_threads;
uint _active_workers;
// Total time for weak processor.
double _total_time_sec;
// Per-worker times and linked items.
WorkerDataArray<double>* _worker_data[EnumRange<WeakProcessorPhase>().size()];
WorkerDataArray<double>* worker_data(WeakProcessorPhase phase) const;
void log_phase_summary(WeakProcessorPhase phase, uint indent) const;
template <typename T>
void log_phase_details(WorkerDataArray<T>* data, uint indent) const;
public:
WeakProcessorPhaseTimes(uint max_threads);
~WeakProcessorPhaseTimes();
uint max_threads() const;
uint active_workers() const;
void set_active_workers(uint n);
double total_time_sec() const;
double worker_time_sec(uint worker_id, WeakProcessorPhase phase) const;
void record_total_time_sec(double time_sec);
void record_worker_time_sec(uint worker_id, WeakProcessorPhase phase, double time_sec);
void record_worker_items(uint worker_id, WeakProcessorPhase phase, size_t num_dead, size_t num_total);
void reset();
void log_print(uint indent = 0) const;
void log_print_phases(uint indent = 0) const;
};
// Record total weak processor time and worker count in times.
// Does nothing if times is NULL.
class WeakProcessorTimeTracker : StackObj {
WeakProcessorPhaseTimes* _times;
Ticks _start_time;
public:
WeakProcessorTimeTracker(WeakProcessorPhaseTimes* times);
~WeakProcessorTimeTracker();
};
// Record phase time contribution for the current thread in phase times.
// Does nothing if phase times is NULL.
class WeakProcessorPhaseTimeTracker : StackObj {
private:
WeakProcessorPhaseTimes* _times;
WeakProcessorPhase _phase;
uint _worker_id;
Ticks _start_time;
public:
// For tracking possibly parallel phase times (even if processed by
// only one thread).
// Precondition: worker_id < times->max_threads().
WeakProcessorPhaseTimeTracker(WeakProcessorPhaseTimes* times,
WeakProcessorPhase phase,
uint worker_id);
~WeakProcessorPhaseTimeTracker();
};
#endif // SHARE_GC_SHARED_WEAKPROCESSORPHASETIMES_HPP