archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-21 03:24:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8028254: gc/arguments/TestMinInitialErgonomics.java failed with unexpected initial heap size

Browse source 
Reviewed-by: brutisso, tschatzl, sjohanss
This commit is contained in:
Erik Helin 2014-02-05 10:09:54 +01:00
parent d52699c497
commit 814dad45e0
2 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
hotspot/src/share/vm/prims/whitebox.cpp
View file

@ -105,7 +105,7 @@ WB_END
WB_ENTRY(void, WB_PrintHeapSizes(JNIEnv* env, jobject o)) { WB_ENTRY(void, WB_PrintHeapSizes(JNIEnv* env, jobject o)) {
CollectorPolicy * p = Universe::heap()->collector_policy(); CollectorPolicy * p = Universe::heap()->collector_policy();
gclog_or_tty->print_cr("Minimum heap "SIZE_FORMAT" Initial heap " gclog_or_tty->print_cr("Minimum heap "SIZE_FORMAT" Initial heap "
SIZE_FORMAT" Maximum heap "SIZE_FORMAT" Min alignment "SIZE_FORMAT" Max alignment "SIZE_FORMAT, SIZE_FORMAT" Maximum heap "SIZE_FORMAT" Space alignment "SIZE_FORMAT" Heap alignment "SIZE_FORMAT,
p->min_heap_byte_size(), p->initial_heap_byte_size(), p->max_heap_byte_size(), p->min_heap_byte_size(), p->initial_heap_byte_size(), p->max_heap_byte_size(),
p->space_alignment(), p->heap_alignment()); p->space_alignment(), p->heap_alignment());
} }

16
hotspot/test/gc/arguments/TestMaxHeapSizeTools.java
View file

@ -41,8 +41,8 @@ final class MinInitialMaxValues {
public long initialHeapSize; public long initialHeapSize;
public long maxHeapSize; public long maxHeapSize;
public long minAlignment; public long spaceAlignment;
public long maxAlignment; public long heapAlignment;
} }
class TestMaxHeapSizeTools { class TestMaxHeapSizeTools {
@ -192,7 +192,7 @@ class TestMaxHeapSizeTools {
// Unfortunately there is no other way to retrieve the minimum heap size and // Unfortunately there is no other way to retrieve the minimum heap size and
// the alignments. // the alignments.
Matcher m = Pattern.compile("Minimum heap \\d+ Initial heap \\d+ Maximum heap \\d+ Min alignment \\d+ Max alignment \\d+"). Matcher m = Pattern.compile("Minimum heap \\d+ Initial heap \\d+ Maximum heap \\d+ Space alignment \\d+ Heap alignment \\d+").
matcher(output.getStdout()); matcher(output.getStdout());
if (!m.find()) { if (!m.find()) {
throw new RuntimeException("Could not find heap size string."); throw new RuntimeException("Could not find heap size string.");
@ -204,8 +204,8 @@ class TestMaxHeapSizeTools {
val.minHeapSize = valueAfter(match, "Minimum heap "); val.minHeapSize = valueAfter(match, "Minimum heap ");
val.initialHeapSize = valueAfter(match, "Initial heap "); val.initialHeapSize = valueAfter(match, "Initial heap ");
val.maxHeapSize = valueAfter(match, "Maximum heap "); val.maxHeapSize = valueAfter(match, "Maximum heap ");
val.minAlignment = valueAfter(match, "Min alignment "); val.spaceAlignment = valueAfter(match, "Space alignment ");
val.maxAlignment = valueAfter(match, "Max alignment "); val.heapAlignment = valueAfter(match, "Heap alignment ");
} }
/** /**
@ -218,12 +218,12 @@ class TestMaxHeapSizeTools {
MinInitialMaxValues v = new MinInitialMaxValues(); MinInitialMaxValues v = new MinInitialMaxValues();
getMinInitialMaxHeap(args, v); getMinInitialMaxHeap(args, v);
if ((expectedMin != -1) && (align_up(expectedMin, v.minAlignment) != v.minHeapSize)) { if ((expectedMin != -1) && (align_up(expectedMin, v.heapAlignment) != v.minHeapSize)) {
throw new RuntimeException("Actual minimum heap size of " + v.minHeapSize + throw new RuntimeException("Actual minimum heap size of " + v.minHeapSize +
" differs from expected minimum heap size of " + expectedMin); " differs from expected minimum heap size of " + expectedMin);
} }
if ((expectedInitial != -1) && (align_up(expectedInitial, v.minAlignment) != v.initialHeapSize)) { if ((expectedInitial != -1) && (align_up(expectedInitial, v.heapAlignment) != v.initialHeapSize)) {
throw new RuntimeException("Actual initial heap size of " + v.initialHeapSize + throw new RuntimeException("Actual initial heap size of " + v.initialHeapSize +
" differs from expected initial heap size of " + expectedInitial); " differs from expected initial heap size of " + expectedInitial);
} }
@ -247,7 +247,7 @@ class TestMaxHeapSizeTools {
MinInitialMaxValues v = new MinInitialMaxValues(); MinInitialMaxValues v = new MinInitialMaxValues();
getMinInitialMaxHeap(new String[] { gcflag, "-XX:MaxHeapSize=" + maxHeapsize + "M" }, v); getMinInitialMaxHeap(new String[] { gcflag, "-XX:MaxHeapSize=" + maxHeapsize + "M" }, v);
long expectedHeapSize = align_up(maxHeapsize * K * K, v.maxAlignment); long expectedHeapSize = align_up(maxHeapsize * K * K, v.heapAlignment);
long actualHeapSize = v.maxHeapSize; long actualHeapSize = v.maxHeapSize;
if (actualHeapSize > expectedHeapSize) { if (actualHeapSize > expectedHeapSize) {