archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-16 09:04:41 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8031401: Remove unused code in the reference processor

Browse source 
Assume pending_list uses discovered field and remove resulting dead code.

Reviewed-by: brutisso, pliden
This commit is contained in:
Kim Barrett 2015-04-23 11:26:32 -04:00
parent 7d01ef4a6e
commit 878cf5e641
8 changed files with 78 additions and 204 deletions
Download patch file Download diff file Expand all files Collapse all files

31
hotspot/src/share/vm/oops/instanceRefKlass.inline.hpp
View file

@ -55,30 +55,17 @@ void InstanceRefKlass::oop_oop_iterate_ref_processing_specialized(oop obj, OopCl
}
}
T* next_addr = (T*)java_lang_ref_Reference::next_addr(obj);
if (ReferenceProcessor::pending_list_uses_discovered_field()) {
T next_oop = oopDesc::load_heap_oop(next_addr);
// Treat discovered as normal oop, if ref is not "active" (next non-NULL)
if (!oopDesc::is_null(next_oop) && contains(disc_addr)) {
// i.e. ref is not "active"
debug_only(
if(TraceReferenceGC && PrintGCDetails) {
gclog_or_tty->print_cr(" Process discovered as normal "
PTR_FORMAT, p2i(disc_addr));
}
)
Devirtualizer<nv>::do_oop(closure, disc_addr);
}
} else {
// In the case of older JDKs which do not use the discovered field for
// the pending list, an inactive ref (next != NULL) must always have a
// NULL discovered field.
T next_oop = oopDesc::load_heap_oop(next_addr);
// Treat discovered as normal oop, if ref is not "active" (next non-NULL)
if (!oopDesc::is_null(next_oop) && contains(disc_addr)) {
// i.e. ref is not "active"
debug_only(
T next_oop = oopDesc::load_heap_oop(next_addr);
T disc_oop = oopDesc::load_heap_oop(disc_addr);
assert(oopDesc::is_null(next_oop) || oopDesc::is_null(disc_oop),
err_msg("Found an inactive reference " PTR_FORMAT " with a non-NULL"
"discovered field", p2i(obj)));
if(TraceReferenceGC && PrintGCDetails) {
gclog_or_tty->print_cr(" Process discovered as normal "
PTR_FORMAT, p2i(disc_addr));
}
)
Devirtualizer<nv>::do_oop(closure, disc_addr);
}
// treat next as normal oop
if (contains(next_addr)) {