archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 14:54:52 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8237890: DatagramPacket::getSocketAddress doesn't specify what happens if address or port are not set

Browse source 
This fix changes the default port of a DatagramPacket from -1 to 0, which changes the behaviour of calling getSocketAddress with no port set from throwing an IAE to returning an InetSocketAddress representing any local address with port 0.

Reviewed-by: alanb, chegar, dfuchs
This commit is contained in:
Patrick Concannon 2020-04-22 12:34:09 +01:00
parent ac088b4631
commit 8e21a2a1e4
5 changed files with 109 additions and 55 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/java.base/share/classes/java/net/DatagramPacket.java
View file

@ -90,8 +90,6 @@ class DatagramPacket {
*/
public DatagramPacket(byte buf[], int offset, int length) {
setData(buf, offset, length);
this.address = null;
this.port = -1;
}
/**
@ -214,7 +212,8 @@ class DatagramPacket {
/**
* Returns the IP address of the machine to which this datagram is being
* sent or from which the datagram was received.
* sent or from which the datagram was received, or {@code null} if not
* set.
*
* @return the IP address of the machine to which this datagram is being
* sent or from which the datagram was received.
@ -227,7 +226,7 @@ class DatagramPacket {
/**
* Returns the port number on the remote host to which this datagram is
* being sent or from which the datagram was received.
* being sent or from which the datagram was received, or 0 if not set.
*
* @return the port number on the remote host to which this datagram is
* being sent or from which the datagram was received.
@ -363,8 +362,10 @@ class DatagramPacket {
}
/**
* Gets the SocketAddress (usually IP address + port number) of the remote
* host that this packet is being sent to or is coming from.
* Returns the {@link InetSocketAddress#InetSocketAddress(InetAddress, int)
* SocketAddress} (usually {@linkplain #getAddress() IP address} +
* {@linkplain #getPort() port number}) of the remote host that this packet
* is being sent to or is coming from.
*
* @return the {@code SocketAddress}
*