archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 15:24:43 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8213383: Wrap up pthread_cond_wait into a loop to workaround potential spurious wakeups

Browse source 
Reviewed-by: dlong, sspitsyn, dholmes, rriggs
This commit is contained in:
Ivan Gerasimov 2018-11-09 16:21:28 -08:00
parent 0f9e314cb5
commit 9076a94dd4
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/java.base/unix/native/libjsig/jsig.c
View file

@ -77,7 +77,7 @@ static __thread bool reentry = false; /* prevent reentry deadlock (per-thread) *
/* Used to synchronize the installation of signal handlers. */
static pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER;
static pthread_cond_t cond = PTHREAD_COND_INITIALIZER;
static pthread_t tid = 0;
static pthread_t tid;
typedef void (*sa_handler_t)(int);
typedef void (*sa_sigaction_t)(int, siginfo_t *, void *);
@ -110,8 +110,11 @@ static void signal_lock() {
/* When the jvm is installing its set of signal handlers, threads
* other than the jvm thread should wait. */
if (jvm_signal_installing) {
if (tid != pthread_self()) {
pthread_cond_wait(&cond, &mutex);
/* tid is not initialized until jvm_signal_installing is set to true. */
if (pthread_equal(tid, pthread_self()) == 0) {
do {
pthread_cond_wait(&cond, &mutex);
} while (jvm_signal_installing);
}
}
}