archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-23 12:34:32 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8151414: os::pretouch_memory should take void* instead of char*

Browse source 
Change parameters and remove associated casts.

Reviewed-by: pliden, stefank
This commit is contained in:
Thomas Schatzl 2016-03-09 09:56:10 +01:00
parent 00a657d109
commit 94c75d0f00
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
hotspot/src/share/vm/gc/parallel/mutableSpace.cpp
View file

@ -58,7 +58,7 @@ void MutableSpace::numa_setup_pages(MemRegion mr, bool clear_space) {
} }
void MutableSpace::pretouch_pages(MemRegion mr) { void MutableSpace::pretouch_pages(MemRegion mr) {
os::pretouch_memory((char*)mr.start(), (char*)mr.end()); os::pretouch_memory(mr.start(), mr.end());
} }
void MutableSpace::initialize(MemRegion mr, void MutableSpace::initialize(MemRegion mr,

4
hotspot/src/share/vm/runtime/os.cpp
View file

@ -1600,8 +1600,8 @@ bool os::release_memory(char* addr, size_t bytes) {
return res; return res;
} }
void os::pretouch_memory(char* start, char* end) { void os::pretouch_memory(void* start, void* end) {
for (volatile char *p = start; p < end; p += os::vm_page_size()) { for (volatile char *p = (char*)start; p < (char*)end; p += os::vm_page_size()) {
*p = 0; *p = 0;
} }
} }

2
hotspot/src/share/vm/runtime/os.hpp
View file

@ -325,7 +325,7 @@ class os: AllStatic {
// to make the OS back the memory range with actual memory. // to make the OS back the memory range with actual memory.
// Current implementation may not touch the last page if unaligned addresses // Current implementation may not touch the last page if unaligned addresses
// are passed. // are passed.
static void pretouch_memory(char* start, char* end); static void pretouch_memory(void* start, void* end);
enum ProtType { MEM_PROT_NONE, MEM_PROT_READ, MEM_PROT_RW, MEM_PROT_RWX }; enum ProtType { MEM_PROT_NONE, MEM_PROT_READ, MEM_PROT_RW, MEM_PROT_RWX };
static bool protect_memory(char* addr, size_t bytes, ProtType prot, static bool protect_memory(char* addr, size_t bytes, ProtType prot,