8332522: SwitchBootstraps::mappedEnumLookup constructs unused array

Reviewed-by: liach, redestad
This commit is contained in:
Jan Lahoda 2024-08-06 09:07:44 +00:00
parent f92c60e1a9
commit 958786b28f
2 changed files with 177 additions and 38 deletions

View file

@ -0,0 +1,105 @@
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
package org.openjdk.bench.java.lang.runtime;
import org.openjdk.jmh.annotations.Benchmark;
import org.openjdk.jmh.annotations.BenchmarkMode;
import org.openjdk.jmh.annotations.Fork;
import org.openjdk.jmh.annotations.Measurement;
import org.openjdk.jmh.annotations.Mode;
import org.openjdk.jmh.annotations.OutputTimeUnit;
import org.openjdk.jmh.annotations.Scope;
import org.openjdk.jmh.annotations.Setup;
import org.openjdk.jmh.annotations.State;
import org.openjdk.jmh.annotations.Warmup;
import java.util.concurrent.TimeUnit;
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
@State(Scope.Thread)
@Warmup(iterations = 5, time = 1, timeUnit = TimeUnit.SECONDS)
@Measurement(iterations = 5, time = 2, timeUnit = TimeUnit.SECONDS)
@Fork(3)
public class SwitchEnum {
public E[] inputs;
@Setup
public void setup() {
inputs = E.values();
}
@Benchmark
public int enumSwitchWithBootstrap() {
int sum = 0;
for (E e : inputs) {
sum += switch (e) {
case null -> -1;
case E0 -> 10;
case E1 -> 11;
case E2 -> 12;
case E3 -> 13;
case E4 -> 14;
case E5 -> 15;
case E6 -> 16;
case E7 -> 17;
case E8 -> 18;
case E9 -> 19;
default -> 17;
};
}
return sum;
}
@Benchmark
public int enumSwitchTraditional() {
int sum = 0;
for (E e : inputs) {
sum += switch (e) {
case E0 -> 10;
case E1 -> 11;
case E2 -> 12;
case E3 -> 13;
case E4 -> 14;
case E5 -> 15;
case E6 -> 16;
case E7 -> 17;
case E8 -> 18;
case E9 -> 19;
default -> 17;
};
}
return sum;
}
public static void main(String[] args) {
SwitchEnum s = new SwitchEnum();
s.setup();
System.out.println(s.enumSwitchWithBootstrap());
System.out.println(s.enumSwitchTraditional());
}
enum E {
E0, E1, E2, E3, E4, E5, E6, E7, E8, E9;
}
}