archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 14:54:52 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8291641: Optimize StackTraceElement.toString()

Browse source 
Reviewed-by: rriggs, mchung
This commit is contained in:
David Schlosnagle 2022-08-10 16:22:19 +00:00 • committed by Mandy Chung
parent cb37282a12
commit 9825c33560
3 changed files with 135 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

59
src/java.base/share/classes/java/lang/StackTraceElement.java
View file

@ -30,7 +30,6 @@ import jdk.internal.misc.VM;
import jdk.internal.module.ModuleHashes;
import jdk.internal.module.ModuleReferenceImpl;
import java.lang.module.ModuleDescriptor.Version;
import java.lang.module.ModuleReference;
import java.lang.module.ResolvedModule;
import java.util.HashSet;
@ -52,6 +51,9 @@ import java.util.Set;
*/
public final class StackTraceElement implements java.io.Serializable {
private static final String NATIVE_METHOD = "Native Method";
private static final String UNKNOWN_SOURCE = "Unknown Source";
// For Throwables and StackWalker, the VM initially sets this field to a
// reference to the declaring Class. The Class reference is used to
// construct the 'format' bitmap, and then is cleared.
@ -355,27 +357,50 @@ public final class StackTraceElement implements java.io.Serializable {
* @revised 9
* @see Throwable#printStackTrace()
*/
@Override
public String toString() {
String s = "";
if (!dropClassLoaderName() && classLoaderName != null &&
!classLoaderName.isEmpty()) {
s += classLoaderName + "/";
}
if (moduleName != null && !moduleName.isEmpty()) {
s += moduleName;
int estimatedLength = length(classLoaderName) + 1
+ length(moduleName) + 1
+ length(moduleVersion) + 1
+ declaringClass.length() + 1
+ methodName.length() + 1
+ Math.max(UNKNOWN_SOURCE.length(), length(fileName)) + 1
+ 12;
if (!dropModuleVersion() && moduleVersion != null &&
!moduleVersion.isEmpty()) {
s += "@" + moduleVersion;
StringBuilder sb = new StringBuilder(estimatedLength);
if (!dropClassLoaderName() && classLoaderName != null && !classLoaderName.isEmpty()) {
sb.append(classLoaderName).append('/');
}
if (moduleName != null && !moduleName.isEmpty()) {
sb.append(moduleName);
if (!dropModuleVersion() && moduleVersion != null && !moduleVersion.isEmpty()) {
sb.append('@').append(moduleVersion);
}
}
s = s.isEmpty() ? declaringClass : s + "/" + declaringClass;
return s + "." + methodName + "(" +
(isNativeMethod() ? "Native Method)" :
(fileName != null && lineNumber >= 0 ?
fileName + ":" + lineNumber + ")" :
(fileName != null ? ""+fileName+")" : "Unknown Source)")));
if (sb.length() > 0) {
sb.append('/');
}
sb.append(declaringClass).append('.').append(methodName).append('(');
if (isNativeMethod()) {
sb.append(NATIVE_METHOD);
} else if (fileName == null) {
sb.append(UNKNOWN_SOURCE);
} else {
sb.append(fileName);
if (lineNumber >= 0) {
sb.append(':').append(lineNumber);
}
}
sb.append(')');
return sb.toString();
}
private static int length(String s) {
return (s == null) ? 0 : s.length();
}
/**