archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 23:04:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8149837: String.intern creates morre work than necessary for G1

Browse source 
Only use the SATB read barrier when reading existing strings from string table, not when adding new strings.

Reviewed-by: stefank, kbarrett
This commit is contained in:
Derek White 2016-02-17 18:02:03 -05:00
parent 3cf4e3909c
commit 98289a12c9
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
hotspot/src/share/vm/classfile/stringTable.cpp
View file

@ -200,7 +200,6 @@ oop StringTable::lookup(jchar* name, int len) {
return string;
}
oop StringTable::intern(Handle string_or_null, jchar* name,
int len, TRAPS) {
oop found_string = lookup_shared(name, len);
@ -214,7 +213,9 @@ oop StringTable::intern(Handle string_or_null, jchar* name,
// Found
if (found_string != NULL) {
ensure_string_alive(found_string);
if (found_string != string_or_null()) {
ensure_string_alive(found_string);
}
return found_string;
}
@ -249,7 +250,9 @@ oop StringTable::intern(Handle string_or_null, jchar* name,
hashValue, CHECK_NULL);
}
ensure_string_alive(added_or_found);
if (added_or_found != string()) {
ensure_string_alive(added_or_found);
}
return added_or_found;
}