archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-26 22:34:27 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8004902: correctness fixes motivated by contended locking work (6607129)

Browse source 
Misc correctness fixes

Reviewed-by: acorn, dholmes, dice, sspitsyn
This commit is contained in:
Dave Dice 2013-01-22 05:56:42 -08:00 • committed by Daniel D. Daugherty
parent 8f1dc20874
commit 98c357abf8
7 changed files with 168 additions and 152 deletions
Download patch file Download diff file Expand all files Collapse all files

9
hotspot/src/share/vm/runtime/objectMonitor.cpp
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 1998, 2012, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1998, 2013, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -653,8 +653,7 @@ void ATTR ObjectMonitor::EnterI (TRAPS) {
assert (_succ != Self, "invariant") ;
if (_Responsible == Self) {
_Responsible = NULL ;
// Dekker pivot-point.
// Consider OrderAccess::storeload() here
OrderAccess::fence(); // Dekker pivot-point
// We may leave threads on cxq|EntryList without a designated
// "Responsible" thread. This is benign. When this thread subsequently
@ -674,10 +673,6 @@ void ATTR ObjectMonitor::EnterI (TRAPS) {
//
// The MEMBAR, above, prevents the LD of cxq|EntryList in the subsequent
// exit operation from floating above the ST Responsible=null.
//
// In *practice* however, EnterI() is always followed by some atomic
// operation such as the decrement of _count in ::enter(). Those atomics
// obviate the need for the explicit MEMBAR, above.
}
// We've acquired ownership with CAS().